From: Sam Ravnborg <sam@ravnborg.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
thierry.reding@gmail.com, kernel@pengutronix.de
Subject: Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821
Date: Fri, 4 Jan 2019 17:38:31 +0100 [thread overview]
Message-ID: <20190104163831.GA10538@ravnborg.org> (raw)
In-Reply-To: <20190103182658.16377-3-m.felsch@pengutronix.de>
Hi Marco.
On Thu, Jan 03, 2019 at 07:26:57PM +0100, Marco Felsch wrote:
> Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> panel to DRM simple panel driver.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> .../bindings/display/panel/evervision,vgg804821.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> new file mode 100644
> index 000000000000..82d22e191ac3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> @@ -0,0 +1,12 @@
> +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> +
> +Required properties:
> +- compatible: should be "evervision,vgg804821"
> +- power-supply: See simple-panel.txt
> +
> +Optional properties:
> +- backlight: See simple-panel.txt
> +- enable-gpios: See simple-panel.txt
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
Other bindings just have the compatible listed and the above two lines and
do not repeat the required/optional properties.
If there is not special reason to add these they I suggest to simplify the binding.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-04 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 18:26 [PATCH 0/3] drm/panel: simple: Add support for Evervision VGG804821 Marco Felsch
2019-01-03 18:26 ` [PATCH 1/3] dt-bindings: add vendor prefix for Evervision Electronics Marco Felsch
2019-01-11 17:01 ` Rob Herring
2019-01-03 18:26 ` [PATCH 2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821 Marco Felsch
2019-01-04 16:38 ` Sam Ravnborg [this message]
2019-01-11 17:01 ` Rob Herring
2019-01-11 17:17 ` Sam Ravnborg
2019-01-11 17:01 ` Rob Herring
2019-01-03 18:26 ` [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support Marco Felsch
2019-01-04 16:40 ` Sam Ravnborg
2019-01-14 10:28 ` Marco Felsch
2019-04-15 15:46 ` Marco Felsch
2019-04-15 16:10 ` Sam Ravnborg
2019-04-15 16:59 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104163831.GA10538@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).