From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Tanglei Han <hantanglei@huawei.com>,
Zhuangluan Su <suzhuangluan@hisilicon.com>,
Ryan Grachek <ryan@edited.us>, Wei Xu <xuwei5@hisilicon.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes
Date: Sat, 5 Jan 2019 09:19:04 +0530 [thread overview]
Message-ID: <20190105034904.GD2477@Mani-XPS-13-9360> (raw)
In-Reply-To: <1546635388-13795-7-git-send-email-john.stultz@linaro.org>
Hi John,
On Fri, Jan 04, 2019 at 12:56:26PM -0800, John Stultz wrote:
> Try to add DMA support to the uart nodes following
> the assignments made in the dts from the victoria vendor kernel
> here:
> https://consumer.huawei.com/en/opensource/detail/?siteCode=worldwide&keywords=p10&fileType=openSourceSoftware&pageSize=10&curPage=1
>
> Cc: Tanglei Han <hantanglei@huawei.com>
> Cc: Zhuangluan Su <suzhuangluan@hisilicon.com>
> Cc: Ryan Grachek <ryan@edited.us>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 20ae40d..aaa2b04 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -466,6 +466,8 @@
> compatible = "arm,pl011", "arm,primecell";
> reg = <0x0 0xfdf02000 0x0 0x1000>;
> interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> + dma-names = "rx", "tx";
> + dmas = <&dma0 0 &dma0 1>;
Usage of DMA channel 0 contradicts with the description provided in
patch, "dma: k3dma: Add support to dma_avail_chan".
Thanks,
Mani
> clocks = <&crg_ctrl HI3660_CLK_MUX_UART0>,
> <&crg_ctrl HI3660_PCLK>;
> clock-names = "uartclk", "apb_pclk";
> @@ -478,6 +480,8 @@
> compatible = "arm,pl011", "arm,primecell";
> reg = <0x0 0xfdf00000 0x0 0x1000>;
> interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> + dma-names = "rx", "tx";
> + dmas = <&dma0 2 &dma0 3>;
> clocks = <&crg_ctrl HI3660_CLK_GATE_UART1>,
> <&crg_ctrl HI3660_CLK_GATE_UART1>;
> clock-names = "uartclk", "apb_pclk";
> @@ -490,6 +494,8 @@
> compatible = "arm,pl011", "arm,primecell";
> reg = <0x0 0xfdf03000 0x0 0x1000>;
> interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> + dma-names = "rx", "tx";
> + dmas = <&dma0 4 &dma0 5>;
> clocks = <&crg_ctrl HI3660_CLK_GATE_UART2>,
> <&crg_ctrl HI3660_PCLK>;
> clock-names = "uartclk", "apb_pclk";
> @@ -514,6 +520,8 @@
> compatible = "arm,pl011", "arm,primecell";
> reg = <0x0 0xfdf01000 0x0 0x1000>;
> interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
> + dma-names = "rx", "tx";
> + dmas = <&dma0 6 &dma0 7>;
> clocks = <&crg_ctrl HI3660_CLK_GATE_UART4>,
> <&crg_ctrl HI3660_CLK_GATE_UART4>;
> clock-names = "uartclk", "apb_pclk";
> @@ -526,6 +534,8 @@
> compatible = "arm,pl011", "arm,primecell";
> reg = <0x0 0xfdf05000 0x0 0x1000>;
> interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> + dma-names = "rx", "tx";
> + dmas = <&dma0 8 &dma0 9>;
> clocks = <&crg_ctrl HI3660_CLK_GATE_UART5>,
> <&crg_ctrl HI3660_CLK_GATE_UART5>;
> clock-names = "uartclk", "apb_pclk";
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-01-05 3:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 20:56 [PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960 John Stultz
2019-01-04 20:56 ` [PATCH 1/8 v2] Documentation: bindings: k3dma: Extend the k3dma driver binding to support hisi-asp John Stultz
2019-01-04 20:56 ` [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan John Stultz
2019-01-05 4:00 ` Manivannan Sadhasivam
2019-01-05 4:39 ` John Stultz
2019-01-05 4:53 ` Manivannan Sadhasivam
2019-01-05 4:58 ` John Stultz
2019-01-05 13:46 ` Vinod Koul
2019-01-05 14:08 ` Manivannan Sadhasivam
2019-01-07 6:24 ` Vinod Koul
2019-01-04 20:56 ` [PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes John Stultz
2019-01-05 3:49 ` Manivannan Sadhasivam [this message]
2019-01-05 4:34 ` John Stultz
2019-01-05 5:37 ` John Stultz
2019-01-04 20:56 ` [PATCH 7/8 v2] arm64: dts: hi3660: Add hisi asp dma device John Stultz
2019-01-05 3:50 ` Manivannan Sadhasivam
2019-01-04 20:56 ` [PATCH 8/8 v2] arm64: dts: hi3660: Fixup unofficial dma-min-chan to dma-avail-chan John Stultz
2019-01-05 3:37 ` [PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960 Manivannan Sadhasivam
2019-01-05 4:28 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105034904.GD2477@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hantanglei@huawei.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryan@edited.us \
--cc=suzhuangluan@hisilicon.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox