From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
linux-omap <linux-omap@vger.kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap3-gta04: Fix graph_port warning
Date: Mon, 7 Jan 2019 10:34:19 -0800 [thread overview]
Message-ID: <20190107183419.GG5544@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+RQMjeH+YTphrXBQRdpUse1rSvPGdJiqcoRQWMPT+-ZQ@mail.gmail.com>
* Rob Herring <robh@kernel.org> [190107 18:32]:
> On Mon, Jan 7, 2019 at 10:21 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
> >
> > Hi Tony,
> >
> > > Am 07.01.2019 um 17:05 schrieb Tony Lindgren <tony@atomide.com>:
> > >
> > > We're currently getting a warning with make dtbs:
> > >
> > > arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port):
> > > /ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit
> > > address error, expected "0"
> >
> > yes, dtc has become more critical nowadays...
> >
> > To me it looks like redundant information, but it is how it is.
>
> If there's only one port, then it is redundant and you should drop reg
> instead. There should be a warning for that too. That one is probably
> off by default as that's more subjective and noisy.
OK dropping this patch. Nikolaus, care to post a better
version since you can test it?
Regards,
Tony
next prev parent reply other threads:[~2019-01-07 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 16:05 [PATCH] ARM: dts: omap3-gta04: Fix graph_port warning Tony Lindgren
2019-01-07 16:21 ` H. Nikolaus Schaller
2019-01-07 18:31 ` Rob Herring
2019-01-07 18:34 ` Tony Lindgren [this message]
2019-01-07 19:34 ` H. Nikolaus Schaller
2019-01-08 7:57 ` Tomi Valkeinen
2019-01-08 15:56 ` Tony Lindgren
2019-01-09 16:46 ` H. Nikolaus Schaller
2019-01-09 17:01 ` Tony Lindgren
2019-01-09 17:42 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107183419.GG5544@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).