From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muru.com ([72.249.23.125]:60344 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbfAGSeW (ORCPT ); Mon, 7 Jan 2019 13:34:22 -0500 Date: Mon, 7 Jan 2019 10:34:19 -0800 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: omap3-gta04: Fix graph_port warning Message-ID: <20190107183419.GG5544@atomide.com> References: <20190107160512.9480-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org To: Rob Herring Cc: "H. Nikolaus Schaller" , linux-omap , =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree@vger.kernel.org List-ID: * Rob Herring [190107 18:32]: > On Mon, Jan 7, 2019 at 10:21 AM H. Nikolaus Schaller wrote: > > > > Hi Tony, > > > > > Am 07.01.2019 um 17:05 schrieb Tony Lindgren : > > > > > > We're currently getting a warning with make dtbs: > > > > > > arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port): > > > /ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit > > > address error, expected "0" > > > > yes, dtc has become more critical nowadays... > > > > To me it looks like redundant information, but it is how it is. > > If there's only one port, then it is redundant and you should drop reg > instead. There should be a warning for that too. That one is probably > off by default as that's more subjective and noisy. OK dropping this patch. Nikolaus, care to post a better version since you can test it? Regards, Tony