* [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
@ 2019-01-07 17:59 Tony Lindgren
2019-01-07 18:37 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tony Lindgren @ 2019-01-07 17:59 UTC (permalink / raw)
To: linux-omap
Cc: Benoît Cousson, devicetree, Pavel Machek, Sebastian Reichel
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed
(regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
This is because of a typo in the irq flags. Really these interrupts
are LEVEL, but before we change them we need to test them. So let's
do a minimal fix first.
Reported-by: Pavel Machek <pavel@ucw.cz>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
--- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
+++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
@@ -105,7 +105,7 @@
interrupts-extended = <
&cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
&cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
- &cpcap 48 1
+ &cpcap 48 0
>;
interrupt-names =
"id_ground", "id_float", "se0conn", "vbusvld",
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
2019-01-07 17:59 [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Tony Lindgren
@ 2019-01-07 18:37 ` Rob Herring
2019-01-07 18:45 ` Tony Lindgren
2019-01-07 18:45 ` Pavel Machek
2019-01-25 16:28 ` Pavel Machek
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2019-01-07 18:37 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, Benoît Cousson, devicetree, Pavel Machek,
Sebastian Reichel
On Mon, Jan 7, 2019 at 11:59 AM Tony Lindgren <tony@atomide.com> wrote:
>
> We're now getting the following error:
>
> genirq: Setting trigger mode 1 for irq 230 failed
> (regmap_irq_set_type+0x0/0x15c)
> cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
>
> This is because of a typo in the irq flags. Really these interrupts
> are LEVEL, but before we change them we need to test them. So let's
> do a minimal fix first.
Hopefully, you mean a driver fix later and not changing the DT again?
A 0 flag is correct if the type is not programmable which I'd guess is
the case here.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
2019-01-07 18:37 ` Rob Herring
@ 2019-01-07 18:45 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2019-01-07 18:45 UTC (permalink / raw)
To: Rob Herring
Cc: linux-omap, Benoît Cousson, devicetree, Pavel Machek,
Sebastian Reichel
* Rob Herring <robh@kernel.org> [190107 18:37]:
> On Mon, Jan 7, 2019 at 11:59 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > We're now getting the following error:
> >
> > genirq: Setting trigger mode 1 for irq 230 failed
> > (regmap_irq_set_type+0x0/0x15c)
> > cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
> >
> > This is because of a typo in the irq flags. Really these interrupts
> > are LEVEL, but before we change them we need to test them. So let's
> > do a minimal fix first.
>
> Hopefully, you mean a driver fix later and not changing the DT again?
> A 0 flag is correct if the type is not programmable which I'd guess is
> the case here.
Oh OK thanks for letting me know. In that case with 0 being correct
for non-programmable interrupts, I'll just drop that paragraph and
no need for further changes. The driver should be already doing the
right thing.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
2019-01-07 17:59 [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Tony Lindgren
2019-01-07 18:37 ` Rob Herring
@ 2019-01-07 18:45 ` Pavel Machek
2019-01-25 16:28 ` Pavel Machek
2 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2019-01-07 18:45 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, Benoît Cousson, devicetree, Sebastian Reichel
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Mon 2019-01-07 09:59:07, Tony Lindgren wrote:
> We're now getting the following error:
>
> genirq: Setting trigger mode 1 for irq 230 failed
> (regmap_irq_set_type+0x0/0x15c)
> cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
>
> This is because of a typo in the irq flags. Really these interrupts
> are LEVEL, but before we change them we need to test them. So let's
> do a minimal fix first.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
Thanks for doing this.
Pavel
Tested-by: Pavel Machek <pavel@ucw.cz>
> --- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> +++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> @@ -105,7 +105,7 @@
> interrupts-extended = <
> &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
> &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
> - &cpcap 48 1
> + &cpcap 48 0
> >;
> interrupt-names =
> "id_ground", "id_float", "se0conn", "vbusvld",
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
2019-01-07 17:59 [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Tony Lindgren
2019-01-07 18:37 ` Rob Herring
2019-01-07 18:45 ` Pavel Machek
@ 2019-01-25 16:28 ` Pavel Machek
2019-01-25 16:53 ` Tony Lindgren
2 siblings, 1 reply; 6+ messages in thread
From: Pavel Machek @ 2019-01-25 16:28 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, Benoît Cousson, devicetree, Sebastian Reichel
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
Hi!
> We're now getting the following error:
>
> genirq: Setting trigger mode 1 for irq 230 failed
> (regmap_irq_set_type+0x0/0x15c)
> cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
>
> This is because of a typo in the irq flags. Really these interrupts
> are LEVEL, but before we change them we need to test them. So let's
> do a minimal fix first.
Could we get this one applied? It is regression fix for 5.0-rc1...
Pavel
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> --- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> +++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> @@ -105,7 +105,7 @@
> interrupts-extended = <
> &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
> &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
> - &cpcap 48 1
> + &cpcap 48 0
> >;
> interrupt-names =
> "id_ground", "id_float", "se0conn", "vbusvld",
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
2019-01-25 16:28 ` Pavel Machek
@ 2019-01-25 16:53 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2019-01-25 16:53 UTC (permalink / raw)
To: Pavel Machek
Cc: linux-omap, Benoît Cousson, devicetree, Sebastian Reichel
* Pavel Machek <pavel@ucw.cz> [190125 16:28]:
> Hi!
>
> > We're now getting the following error:
> >
> > genirq: Setting trigger mode 1 for irq 230 failed
> > (regmap_irq_set_type+0x0/0x15c)
> > cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
> >
> > This is because of a typo in the irq flags. Really these interrupts
> > are LEVEL, but before we change them we need to test them. So let's
> > do a minimal fix first.
>
> Could we get this one applied? It is regression fix for 5.0-rc1...
Yes thanks for reminding me, was planning to send off
the first set earlier but got hit with more regressions
and delays. Anyways, I just sent a pull request for
the dts regressions.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-25 16:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-07 17:59 [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Tony Lindgren
2019-01-07 18:37 ` Rob Herring
2019-01-07 18:45 ` Tony Lindgren
2019-01-07 18:45 ` Pavel Machek
2019-01-25 16:28 ` Pavel Machek
2019-01-25 16:53 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).