From mboxrd@z Thu Jan 1 00:00:00 1970 From: "gregkh@linuxfoundation.org" Subject: Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver Date: Tue, 8 Jan 2019 19:12:06 +0100 Message-ID: <20190108181206.GA3848@kroah.com> References: <20190108104204.GA14243@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: James Morse Cc: Borislav Petkov , "Wiebe, Wladislav (Nokia - DE/Ulm)" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "nicolas.ferre@microchip.com" , "arnd@arndb.de" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mchehab@kernel.org" , "Sverdlin, Alexander (Nokia - DE/Ulm)" , "devicetree@vger.kernel.org" , linux-kernel@vger.ker List-Id: devicetree@vger.kernel.org On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: > >> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c > >> new file mode 100644 > >> index 000000000000..26252568e961 > >> --- /dev/null > >> +++ b/drivers/edac/cortex_a15_l2_async_edac.c > >> @@ -0,0 +1,134 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) 2018 Nokia Corporation > > (boiler plate not needed with the SPDX header) Not true at all. Copyright is not the same thing as an SPDX license identifier in any way, shape, or form. As-is, this is just fine. Now I will not go into the issues where a "Copyright..." line really means nothing at all anymore, as lawyers like to cargo-cult worse than programmers do, so it's good to have those lines there just to make them happy :) thanks, greg k-h