* [PATCH] ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2
@ 2019-01-08 19:18 Jernej Skrabec
[not found] ` <20190108191840.16007-1-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Jernej Skrabec @ 2019-01-08 19:18 UTC (permalink / raw)
To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ, wens-jdAy2FN1RRM
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
Because "ethernet0" alias is missing, U-Boot doesn't generate board
specific MAC address. Effect of this is random MAC address every boot
and thus new IP address is assigned to the board.
Fix this by adding alias.
Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
---
arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
index 5d23667dc2d2..671600d6bb53 100644
--- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
@@ -54,6 +54,7 @@
aliases {
serial0 = &uart0;
/* ethernet0 is the H3 emac, defined in sun8i-h3.dtsi */
+ ethernet0 = &emac;
ethernet1 = &sdiowifi;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <20190108191840.16007-1-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>]
* Re: [PATCH] ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2 [not found] ` <20190108191840.16007-1-jernej.skrabec-gGgVlfcn5nU@public.gmane.org> @ 2019-01-09 10:12 ` Maxime Ripard 2019-01-09 10:13 ` Chen-Yu Tsai 0 siblings, 1 reply; 4+ messages in thread From: Maxime Ripard @ 2019-01-09 10:12 UTC (permalink / raw) To: Jernej Skrabec Cc: wens-jdAy2FN1RRM, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 480 bytes --] On Tue, Jan 08, 2019 at 08:18:40PM +0100, Jernej Skrabec wrote: > Because "ethernet0" alias is missing, U-Boot doesn't generate board > specific MAC address. Effect of this is random MAC address every boot > and thus new IP address is assigned to the board. > > Fix this by adding alias. > > Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org> Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2 2019-01-09 10:12 ` Maxime Ripard @ 2019-01-09 10:13 ` Chen-Yu Tsai [not found] ` <CAGb2v64QM9gyPTtpw0C0fpANW5R9DEsWFSDA_tJPYhdgF_FAhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Chen-Yu Tsai @ 2019-01-09 10:13 UTC (permalink / raw) To: Maxime Ripard Cc: Jernej Skrabec, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Wed, Jan 9, 2019 at 6:12 PM Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> wrote: > > On Tue, Jan 08, 2019 at 08:18:40PM +0100, Jernej Skrabec wrote: > > Because "ethernet0" alias is missing, U-Boot doesn't generate board > > specific MAC address. Effect of this is random MAC address every boot > > and thus new IP address is assigned to the board. > > > > Fix this by adding alias. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org> > > Applied, thanks! > Maxime Might we add a fixes tag, so the patch gets backported? ChenYu ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAGb2v64QM9gyPTtpw0C0fpANW5R9DEsWFSDA_tJPYhdgF_FAhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2 [not found] ` <CAGb2v64QM9gyPTtpw0C0fpANW5R9DEsWFSDA_tJPYhdgF_FAhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2019-01-09 10:20 ` Maxime Ripard 0 siblings, 0 replies; 4+ messages in thread From: Maxime Ripard @ 2019-01-09 10:20 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Jernej Skrabec, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 804 bytes --] On Wed, Jan 09, 2019 at 06:13:24PM +0800, Chen-Yu Tsai wrote: > On Wed, Jan 9, 2019 at 6:12 PM Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> wrote: > > > > On Tue, Jan 08, 2019 at 08:18:40PM +0100, Jernej Skrabec wrote: > > > Because "ethernet0" alias is missing, U-Boot doesn't generate board > > > specific MAC address. Effect of this is random MAC address every boot > > > and thus new IP address is assigned to the board. > > > > > > Fix this by adding alias. > > > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org> > > > > Applied, thanks! > > Maxime > > Might we add a fixes tag, so the patch gets backported? It's done, thanks for the suggestion! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-09 10:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-08 19:18 [PATCH] ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2 Jernej Skrabec
[not found] ` <20190108191840.16007-1-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
2019-01-09 10:12 ` Maxime Ripard
2019-01-09 10:13 ` Chen-Yu Tsai
[not found] ` <CAGb2v64QM9gyPTtpw0C0fpANW5R9DEsWFSDA_tJPYhdgF_FAhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-01-09 10:20 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).