* [PATCH 0/3] dts: fsl: lsch2: dts modifications for chassis 2 devices
@ 2018-12-12 7:09 Pankaj Bansal
2018-12-12 7:09 ` [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices Pankaj Bansal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Pankaj Bansal @ 2018-12-12 7:09 UTC (permalink / raw)
To: linux-arm-kernel@lists.infradead.org, Shawn Guo, Leo Li
Cc: devicetree@vger.kernel.org, Pankaj Bansal, Varun Sethi
This patch series fixes some issues with the chassis 2 bases dts/dtsi
files.
The reference for patches is as follows:
patch 1 : https://elinux.org/Device_Tree_Linux#disabled_nodes
patch 2 : https://elixir.bootlin.com/linux/v4.19.8/source/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts#L121
patch 3 : https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/common-properties.txt
Cc: Varun Sethi <V.Sethi@nxp.com>
Pankaj Bansal (3):
dts: arm64: fsl: lsch2: fix status field of serdes controlled devices
dts: arm64: fsl: lsch2: fix the rgmii phy type
dts: arm64: fsl: lsch2: Fix the endianness property in nodes
.../boot/dts/freescale/fsl-ls1043a-qds.dts | 18 ++++++++++++
.../boot/dts/freescale/fsl-ls1043a-rdb.dts | 17 +++++++++++
.../arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 4 +++
.../boot/dts/freescale/fsl-ls1046a-qds.dts | 18 ++++++++++++
.../boot/dts/freescale/fsl-ls1046a-rdb.dts | 28 +++++++++++++++++--
.../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++--
.../dts/freescale/qoriq-fman3-0-10g-0.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-10g-1.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-0.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-1.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-2.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-3.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-4.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-5.dtsi | 1 +
14 files changed, 95 insertions(+), 4 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices
2018-12-12 7:09 [PATCH 0/3] dts: fsl: lsch2: dts modifications for chassis 2 devices Pankaj Bansal
@ 2018-12-12 7:09 ` Pankaj Bansal
2019-01-11 2:38 ` Shawn Guo
2018-12-12 7:09 ` [PATCH 2/3] dts: arm64: fsl: lsch2: fix the rgmii phy type Pankaj Bansal
2018-12-12 7:09 ` [PATCH 3/3] dts: arm64: fsl: lsch2: Fix the endianness property in nodes Pankaj Bansal
2 siblings, 1 reply; 5+ messages in thread
From: Pankaj Bansal @ 2018-12-12 7:09 UTC (permalink / raw)
To: linux-arm-kernel@lists.infradead.org, Shawn Guo, Leo Li
Cc: devicetree@vger.kernel.org, Pankaj Bansal
This patch disables that devices that are controlled by serdes
(pcie, sata, ethernet macs) in SOC dtsi files and enables the
interfaces in board dts file.
Actually this practise should be followed for all the devices and
not for only serdes controlled devices.
refer https://elinux.org/Device_Tree_Linux#disabled_nodes
Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
---
.../boot/dts/freescale/fsl-ls1043a-qds.dts | 18 +++++++++++++
.../boot/dts/freescale/fsl-ls1043a-rdb.dts | 17 +++++++++++++
.../boot/dts/freescale/fsl-ls1043a.dtsi | 1 +
.../boot/dts/freescale/fsl-ls1046a-qds.dts | 18 +++++++++++++
.../boot/dts/freescale/fsl-ls1046a-rdb.dts | 24 ++++++++++++++++++
.../boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-10g-0.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-10g-1.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-0.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-1.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-2.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-3.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-4.dtsi | 1 +
.../dts/freescale/qoriq-fman3-0-1g-5.dtsi | 1 +
14 files changed, 87 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index dff3d648172e..384b21f8a606 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -65,6 +65,20 @@
compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
reg = <0x2 0x0 0x0000100>;
};
+
+ soc {
+ pcie@3400000 {
+ status = "okay";
+ };
+
+ pcie@3500000 {
+ status = "okay";
+ };
+
+ pcie@3600000 {
+ status = "okay";
+ };
+ };
};
&i2c0 {
@@ -147,4 +161,8 @@
};
};
+&sata {
+ status = "okay";
+};
+
#include "fsl-ls1043-post.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 17ca357e854f..50a744c3c428 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -25,6 +25,16 @@
chosen {
stdout-path = "serial0:115200n8";
};
+
+ soc {
+ pcie@3500000 {
+ status = "okay";
+ };
+
+ pcie@3600000 {
+ status = "okay";
+ };
+ };
};
&i2c0 {
@@ -111,36 +121,43 @@
ethernet@e0000 {
phy-handle = <&qsgmii_phy1>;
phy-connection-type = "qsgmii";
+ status = "okay";
};
ethernet@e2000 {
phy-handle = <&qsgmii_phy2>;
phy-connection-type = "qsgmii";
+ status = "okay";
};
ethernet@e4000 {
phy-handle = <&rgmii_phy1>;
phy-connection-type = "rgmii-txid";
+ status = "okay";
};
ethernet@e6000 {
phy-handle = <&rgmii_phy2>;
phy-connection-type = "rgmii-txid";
+ status = "okay";
};
ethernet@e8000 {
phy-handle = <&qsgmii_phy3>;
phy-connection-type = "qsgmii";
+ status = "okay";
};
ethernet@ea000 {
phy-handle = <&qsgmii_phy4>;
phy-connection-type = "qsgmii";
+ status = "okay";
};
ethernet@f0000 { /* 10GEC1 */
phy-handle = <&aqr105_phy>;
phy-connection-type = "xgmii";
+ status = "okay";
};
mdio@fc000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 70057b4e46e8..eea23b84daee 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -639,6 +639,7 @@
interrupts = <0 69 0x4>;
clocks = <&clockgen 4 0>;
dma-coherent;
+ status = "disabled";
};
msi1: msi-controller1@1571000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index e58a8ca1386c..1c3ccf17a554 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -30,6 +30,20 @@
chosen {
stdout-path = "serial0:115200n8";
};
+
+ soc {
+ pcie@3400000 {
+ status = "okay";
+ };
+
+ pcie@3500000 {
+ status = "okay";
+ };
+
+ pcie@3600000 {
+ status = "okay";
+ };
+ };
};
&dspi {
@@ -176,4 +190,8 @@
};
};
+&sata {
+ status = "okay";
+};
+
#include "fsl-ls1046-post.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index a59b48203688..65ea27c8341a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -25,6 +25,20 @@
chosen {
stdout-path = "serial0:115200n8";
};
+
+ soc {
+ pcie@3400000 {
+ status = "okay";
+ };
+
+ pcie@3500000 {
+ status = "okay";
+ };
+
+ pcie@3600000 {
+ status = "okay";
+ };
+ };
};
&duart0 {
@@ -120,37 +134,47 @@
};
};
+&sata {
+ status = "okay";
+};
+
#include "fsl-ls1046-post.dtsi"
&fman0 {
ethernet@e4000 {
phy-handle = <&rgmii_phy1>;
phy-connection-type = "rgmii";
+ status = "okay";
};
ethernet@e6000 {
phy-handle = <&rgmii_phy2>;
phy-connection-type = "rgmii";
+ status = "okay";
};
ethernet@e8000 {
phy-handle = <&sgmii_phy1>;
phy-connection-type = "sgmii";
+ status = "okay";
};
ethernet@ea000 {
phy-handle = <&sgmii_phy2>;
phy-connection-type = "sgmii";
+ status = "okay";
};
ethernet@f0000 { /* 10GEC1 */
phy-handle = <&aqr106_phy>;
phy-connection-type = "xgmii";
+ status = "okay";
};
ethernet@f2000 { /* 10GEC2 */
fixed-link = <0 1 1000 0 0>;
phy-connection-type = "xgmii";
+ status = "okay";
};
mdio@fc000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 9a2106e60e19..49a363abf2ad 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -599,6 +599,7 @@
reg-names = "ahci", "sata-ecc";
interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clockgen 4 1>;
+ status = "disabled";
};
msi1: msi-controller@1580000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi
index dbd2fc3ba790..515be7448e3e 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi
@@ -27,6 +27,7 @@ fman@1a00000 {
reg = <0xf0000 0x1000>;
fsl,fman-ports = <&fman0_rx_0x10 &fman0_tx_0x30>;
pcsphy-handle = <&pcsphy6>;
+ status = "disabled";
};
mdio@f1000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi
index 6fc5d2560057..3fc43b0faa3f 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi
@@ -27,6 +27,7 @@ fman@1a00000 {
reg = <0xf2000 0x1000>;
fsl,fman-ports = <&fman0_rx_0x11 &fman0_tx_0x31>;
pcsphy-handle = <&pcsphy7>;
+ status = "disabled";
};
mdio@f3000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi
index 4e02276fcf99..fa16a914e53b 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi
@@ -26,6 +26,7 @@ fman@1a00000 {
fsl,fman-ports = <&fman0_rx_0x08 &fman0_tx_0x28>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy0>;
+ status = "disabled";
};
mdio@e1000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi
index 0312fa43fa77..8813d433d891 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi
@@ -26,6 +26,7 @@ fman@1a00000 {
fsl,fman-ports = <&fman0_rx_0x09 &fman0_tx_0x29>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy1>;
+ status = "disabled";
};
mdio@e3000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi
index af2df07971dd..65663d449430 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi
@@ -26,6 +26,7 @@ fman@1a00000 {
fsl,fman-ports = <&fman0_rx_0x0a &fman0_tx_0x2a>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy2>;
+ status = "disabled";
};
mdio@e5000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi
index 4ac98dc8b227..8ae370f11518 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi
@@ -26,6 +26,7 @@ fman@1a00000 {
fsl,fman-ports = <&fman0_rx_0x0b &fman0_tx_0x2b>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy3>;
+ status = "disabled";
};
mdio@e7000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi
index bd932d8b0160..3ff5a97e0a58 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi
@@ -26,6 +26,7 @@ fman@1a00000 {
fsl,fman-ports = <&fman0_rx_0x0c &fman0_tx_0x2c>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy4>;
+ status = "disabled";
};
mdio@e9000 {
diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi
index 7de1c5203f3e..4e9bd0b25499 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi
@@ -26,6 +26,7 @@ fman@1a00000 {
fsl,fman-ports = <&fman0_rx_0x0d &fman0_tx_0x2d>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy5>;
+ status = "disabled";
};
mdio@eb000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] dts: arm64: fsl: lsch2: fix the rgmii phy type
2018-12-12 7:09 [PATCH 0/3] dts: fsl: lsch2: dts modifications for chassis 2 devices Pankaj Bansal
2018-12-12 7:09 ` [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices Pankaj Bansal
@ 2018-12-12 7:09 ` Pankaj Bansal
2018-12-12 7:09 ` [PATCH 3/3] dts: arm64: fsl: lsch2: Fix the endianness property in nodes Pankaj Bansal
2 siblings, 0 replies; 5+ messages in thread
From: Pankaj Bansal @ 2018-12-12 7:09 UTC (permalink / raw)
To: linux-arm-kernel@lists.infradead.org, Shawn Guo, Leo Li
Cc: devicetree@vger.kernel.org, Pankaj Bansal
refer fsl-ls1043a-rdb.dts. The phy connection type for RGMII phy in
Layerscape boards is "rgmii-txid" and not "rgmii".
Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 65ea27c8341a..540231b41997 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -143,13 +143,13 @@
&fman0 {
ethernet@e4000 {
phy-handle = <&rgmii_phy1>;
- phy-connection-type = "rgmii";
+ phy-connection-type = "rgmii-txid";
status = "okay";
};
ethernet@e6000 {
phy-handle = <&rgmii_phy2>;
- phy-connection-type = "rgmii";
+ phy-connection-type = "rgmii-txid";
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] dts: arm64: fsl: lsch2: Fix the endianness property in nodes
2018-12-12 7:09 [PATCH 0/3] dts: fsl: lsch2: dts modifications for chassis 2 devices Pankaj Bansal
2018-12-12 7:09 ` [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices Pankaj Bansal
2018-12-12 7:09 ` [PATCH 2/3] dts: arm64: fsl: lsch2: fix the rgmii phy type Pankaj Bansal
@ 2018-12-12 7:09 ` Pankaj Bansal
2 siblings, 0 replies; 5+ messages in thread
From: Pankaj Bansal @ 2018-12-12 7:09 UTC (permalink / raw)
To: linux-arm-kernel@lists.infradead.org, Shawn Guo, Leo Li
Cc: devicetree@vger.kernel.org, Pankaj Bansal
The endianness ought to be mentioned in dts nodes if the device
is big endian. this helps the software to read/write device registers.
refer Documentation/devicetree/bindings/common-properties.txt
Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 +++
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index eea23b84daee..9e497757229f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -240,6 +240,7 @@
ranges = <0x0 0x00 0x1700000 0x100000>;
reg = <0x00 0x1700000 0x0 0x100000>;
interrupts = <0 75 0x4>;
+ big-endian;
sec_jr0: jr@10000 {
compatible = "fsl,sec-v5.4-job-ring",
@@ -367,6 +368,7 @@
reg = <0x0 0x1880000 0x0 0x10000>;
interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
memory-region = <&qman_fqd &qman_pfdr>;
+ big-endian;
};
bman: bman@1890000 {
@@ -374,6 +376,7 @@
reg = <0x0 0x1890000 0x0 0x10000>;
interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
memory-region = <&bman_fbpr>;
+ big-endian;
};
bportals: bman-portals@508000000 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 49a363abf2ad..60a0bad946ed 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -245,6 +245,7 @@
ranges = <0x0 0x00 0x1700000 0x100000>;
reg = <0x00 0x1700000 0x0 0x100000>;
interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+ big-endian;
sec_jr0: jr@10000 {
compatible = "fsl,sec-v5.4-job-ring",
@@ -284,7 +285,7 @@
reg = <0x0 0x1880000 0x0 0x10000>;
interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
memory-region = <&qman_fqd &qman_pfdr>;
-
+ big-endian;
};
bman: bman@1890000 {
@@ -292,7 +293,7 @@
reg = <0x0 0x1890000 0x0 0x10000>;
interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
memory-region = <&bman_fbpr>;
-
+ big-endian;
};
qportals: qman-portals@500000000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices
2018-12-12 7:09 ` [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices Pankaj Bansal
@ 2019-01-11 2:38 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-01-11 2:38 UTC (permalink / raw)
To: Pankaj Bansal
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Leo Li
On Wed, Dec 12, 2018 at 07:09:54AM +0000, Pankaj Bansal wrote:
> This patch disables that devices that are controlled by serdes
> (pcie, sata, ethernet macs) in SOC dtsi files and enables the
> interfaces in board dts file.
>
> Actually this practise should be followed for all the devices and
> not for only serdes controlled devices.
>
> refer https://elinux.org/Device_Tree_Linux#disabled_nodes
>
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
The subject prefix should be 'arm64: dts: ...'
> ---
> .../boot/dts/freescale/fsl-ls1043a-qds.dts | 18 +++++++++++++
> .../boot/dts/freescale/fsl-ls1043a-rdb.dts | 17 +++++++++++++
> .../boot/dts/freescale/fsl-ls1043a.dtsi | 1 +
> .../boot/dts/freescale/fsl-ls1046a-qds.dts | 18 +++++++++++++
> .../boot/dts/freescale/fsl-ls1046a-rdb.dts | 24 ++++++++++++++++++
> .../boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-10g-0.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-10g-1.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-1g-0.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-1g-1.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-1g-2.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-1g-3.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-1g-4.dtsi | 1 +
> .../dts/freescale/qoriq-fman3-0-1g-5.dtsi | 1 +
> 14 files changed, 87 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index dff3d648172e..384b21f8a606 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -65,6 +65,20 @@
> compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
> reg = <0x2 0x0 0x0000100>;
> };
> +
> + soc {
> + pcie@3400000 {
Can we label these devices in <soc>.dtsi and flip the 'status' using
labeling node, just like &sata below?
Shawn
> + status = "okay";
> + };
> +
> + pcie@3500000 {
> + status = "okay";
> + };
> +
> + pcie@3600000 {
> + status = "okay";
> + };
> + };
> };
>
> &i2c0 {
> @@ -147,4 +161,8 @@
> };
> };
>
> +&sata {
> + status = "okay";
> +};
> +
> #include "fsl-ls1043-post.dtsi"
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 17ca357e854f..50a744c3c428 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -25,6 +25,16 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + soc {
> + pcie@3500000 {
> + status = "okay";
> + };
> +
> + pcie@3600000 {
> + status = "okay";
> + };
> + };
> };
>
> &i2c0 {
> @@ -111,36 +121,43 @@
> ethernet@e0000 {
> phy-handle = <&qsgmii_phy1>;
> phy-connection-type = "qsgmii";
> + status = "okay";
> };
>
> ethernet@e2000 {
> phy-handle = <&qsgmii_phy2>;
> phy-connection-type = "qsgmii";
> + status = "okay";
> };
>
> ethernet@e4000 {
> phy-handle = <&rgmii_phy1>;
> phy-connection-type = "rgmii-txid";
> + status = "okay";
> };
>
> ethernet@e6000 {
> phy-handle = <&rgmii_phy2>;
> phy-connection-type = "rgmii-txid";
> + status = "okay";
> };
>
> ethernet@e8000 {
> phy-handle = <&qsgmii_phy3>;
> phy-connection-type = "qsgmii";
> + status = "okay";
> };
>
> ethernet@ea000 {
> phy-handle = <&qsgmii_phy4>;
> phy-connection-type = "qsgmii";
> + status = "okay";
> };
>
> ethernet@f0000 { /* 10GEC1 */
> phy-handle = <&aqr105_phy>;
> phy-connection-type = "xgmii";
> + status = "okay";
> };
>
> mdio@fc000 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index 70057b4e46e8..eea23b84daee 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -639,6 +639,7 @@
> interrupts = <0 69 0x4>;
> clocks = <&clockgen 4 0>;
> dma-coherent;
> + status = "disabled";
> };
>
> msi1: msi-controller1@1571000 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index e58a8ca1386c..1c3ccf17a554 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -30,6 +30,20 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + soc {
> + pcie@3400000 {
> + status = "okay";
> + };
> +
> + pcie@3500000 {
> + status = "okay";
> + };
> +
> + pcie@3600000 {
> + status = "okay";
> + };
> + };
> };
>
> &dspi {
> @@ -176,4 +190,8 @@
> };
> };
>
> +&sata {
> + status = "okay";
> +};
> +
> #include "fsl-ls1046-post.dtsi"
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index a59b48203688..65ea27c8341a 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -25,6 +25,20 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + soc {
> + pcie@3400000 {
> + status = "okay";
> + };
> +
> + pcie@3500000 {
> + status = "okay";
> + };
> +
> + pcie@3600000 {
> + status = "okay";
> + };
> + };
> };
>
> &duart0 {
> @@ -120,37 +134,47 @@
> };
> };
>
> +&sata {
> + status = "okay";
> +};
> +
> #include "fsl-ls1046-post.dtsi"
>
> &fman0 {
> ethernet@e4000 {
> phy-handle = <&rgmii_phy1>;
> phy-connection-type = "rgmii";
> + status = "okay";
> };
>
> ethernet@e6000 {
> phy-handle = <&rgmii_phy2>;
> phy-connection-type = "rgmii";
> + status = "okay";
> };
>
> ethernet@e8000 {
> phy-handle = <&sgmii_phy1>;
> phy-connection-type = "sgmii";
> + status = "okay";
> };
>
> ethernet@ea000 {
> phy-handle = <&sgmii_phy2>;
> phy-connection-type = "sgmii";
> + status = "okay";
> };
>
> ethernet@f0000 { /* 10GEC1 */
> phy-handle = <&aqr106_phy>;
> phy-connection-type = "xgmii";
> + status = "okay";
> };
>
> ethernet@f2000 { /* 10GEC2 */
> fixed-link = <0 1 1000 0 0>;
> phy-connection-type = "xgmii";
> + status = "okay";
> };
>
> mdio@fc000 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 9a2106e60e19..49a363abf2ad 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -599,6 +599,7 @@
> reg-names = "ahci", "sata-ecc";
> interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clockgen 4 1>;
> + status = "disabled";
> };
>
> msi1: msi-controller@1580000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi
> index dbd2fc3ba790..515be7448e3e 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-0.dtsi
> @@ -27,6 +27,7 @@ fman@1a00000 {
> reg = <0xf0000 0x1000>;
> fsl,fman-ports = <&fman0_rx_0x10 &fman0_tx_0x30>;
> pcsphy-handle = <&pcsphy6>;
> + status = "disabled";
> };
>
> mdio@f1000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi
> index 6fc5d2560057..3fc43b0faa3f 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-10g-1.dtsi
> @@ -27,6 +27,7 @@ fman@1a00000 {
> reg = <0xf2000 0x1000>;
> fsl,fman-ports = <&fman0_rx_0x11 &fman0_tx_0x31>;
> pcsphy-handle = <&pcsphy7>;
> + status = "disabled";
> };
>
> mdio@f3000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi
> index 4e02276fcf99..fa16a914e53b 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi
> @@ -26,6 +26,7 @@ fman@1a00000 {
> fsl,fman-ports = <&fman0_rx_0x08 &fman0_tx_0x28>;
> ptp-timer = <&ptp_timer0>;
> pcsphy-handle = <&pcsphy0>;
> + status = "disabled";
> };
>
> mdio@e1000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi
> index 0312fa43fa77..8813d433d891 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-1.dtsi
> @@ -26,6 +26,7 @@ fman@1a00000 {
> fsl,fman-ports = <&fman0_rx_0x09 &fman0_tx_0x29>;
> ptp-timer = <&ptp_timer0>;
> pcsphy-handle = <&pcsphy1>;
> + status = "disabled";
> };
>
> mdio@e3000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi
> index af2df07971dd..65663d449430 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-2.dtsi
> @@ -26,6 +26,7 @@ fman@1a00000 {
> fsl,fman-ports = <&fman0_rx_0x0a &fman0_tx_0x2a>;
> ptp-timer = <&ptp_timer0>;
> pcsphy-handle = <&pcsphy2>;
> + status = "disabled";
> };
>
> mdio@e5000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi
> index 4ac98dc8b227..8ae370f11518 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-3.dtsi
> @@ -26,6 +26,7 @@ fman@1a00000 {
> fsl,fman-ports = <&fman0_rx_0x0b &fman0_tx_0x2b>;
> ptp-timer = <&ptp_timer0>;
> pcsphy-handle = <&pcsphy3>;
> + status = "disabled";
> };
>
> mdio@e7000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi
> index bd932d8b0160..3ff5a97e0a58 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-4.dtsi
> @@ -26,6 +26,7 @@ fman@1a00000 {
> fsl,fman-ports = <&fman0_rx_0x0c &fman0_tx_0x2c>;
> ptp-timer = <&ptp_timer0>;
> pcsphy-handle = <&pcsphy4>;
> + status = "disabled";
> };
>
> mdio@e9000 {
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi
> index 7de1c5203f3e..4e9bd0b25499 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-5.dtsi
> @@ -26,6 +26,7 @@ fman@1a00000 {
> fsl,fman-ports = <&fman0_rx_0x0d &fman0_tx_0x2d>;
> ptp-timer = <&ptp_timer0>;
> pcsphy-handle = <&pcsphy5>;
> + status = "disabled";
> };
>
> mdio@eb000 {
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-11 2:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12 7:09 [PATCH 0/3] dts: fsl: lsch2: dts modifications for chassis 2 devices Pankaj Bansal
2018-12-12 7:09 ` [PATCH 1/3] dts: arm64: fsl: lsch2: fix status field of serdes controlled devices Pankaj Bansal
2019-01-11 2:38 ` Shawn Guo
2018-12-12 7:09 ` [PATCH 2/3] dts: arm64: fsl: lsch2: fix the rgmii phy type Pankaj Bansal
2018-12-12 7:09 ` [PATCH 3/3] dts: arm64: fsl: lsch2: Fix the endianness property in nodes Pankaj Bansal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).