From: Brian Masney <masneyb@onstation.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: andy.gross@linaro.org, bjorn.andersson@linaro.org,
linus.walleij@linaro.org, marc.zyngier@arm.com,
shawnguo@kernel.org, dianders@chromium.org,
linux-gpio@vger.kernel.org, nicolas.dechesne@linaro.org,
niklas.cassel@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/6] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips
Date: Fri, 11 Jan 2019 18:00:04 -0500 [thread overview]
Message-ID: <20190111230004.GA5805@basecamp> (raw)
In-Reply-To: <154724442941.169631.5308212449003169927@swboyd.mtv.corp.google.com>
On Fri, Jan 11, 2019 at 02:07:09PM -0800, Stephen Boyd wrote:
> Quoting Brian Masney (2019-01-09 17:12:54)
> > Convert the spmi-pmic-arb IRQ code to use the version 2 IRQ interface
> > in order to support hierarchical IRQ chips. This is necessary so that
> > spmi-gpio can be setup as a hierarchical IRQ chip with pmic-arb as the
> > parent. IRQ chips in device tree should be usable from the start without
> > the consumer having to make an additional call to gpio[d]_to_irq() to
> > get the proper IRQ on the parent. Driver was tested on a LG Nexus 5
> > (hammerhead) phone.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > ---
> > Changes since v2:
> > - None
> >
> > Changes since v1:
> > - Add intspec variable to qpnpint_irq_domain_translate to reduce the
> > overall diff.
> > - Remove irq_domain_disassociate hack.
>
> I thought we would need to keep that around? And then dispose of the
> hack later on. Won't this just wreck the world almost immediately
> because the MFD is counting irqs from DT?
We won't run into the issue with the MFD counting the IRQs since the
interrupts property was removed and the interrupt-controller property
was added to device tree in the same patch. The interrupts property that
we ultimately don't need was the issue that I ran into with the MFD
subsystem.
However to be certain, I retested and we need the temporary hack since
pmic_gpio_to_irq in this series uses the new SPMI IRQ controller. It
breaks as soon as patch 4 in this series (qcom: spmi-gpio: add support
for hierarchical IRQ chip) is applied but starts working again at patch
5 (ARM: dts: qcom: pm8941: add interrupt controller).
I'll respin this series this weekend with the temporary hack and drop it
later in the series. Sorry about the noise and thanks for the
reviewed-bys.
Brian
next prev parent reply other threads:[~2019-01-11 23:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 1:12 [PATCH v3 0/6] qcom: spmi: add support for hierarchical IRQ chip Brian Masney
2019-01-10 1:12 ` [PATCH v3 1/6] pinctrl: qcom: spmi-gpio: hardcode IRQ counts Brian Masney
2019-01-11 22:00 ` Stephen Boyd
2019-01-10 1:12 ` [PATCH v3 2/6] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips Brian Masney
2019-01-11 22:07 ` Stephen Boyd
2019-01-11 23:00 ` Brian Masney [this message]
2019-01-11 23:39 ` Stephen Boyd
2019-01-12 1:34 ` Brian Masney
2019-01-10 1:12 ` [PATCH v3 3/6] gpio: add irq domain activate/deactivate functions Brian Masney
2019-01-11 22:05 ` Stephen Boyd
2019-01-10 1:12 ` [PATCH v3 4/6] qcom: spmi-gpio: add support for hierarchical IRQ chip Brian Masney
2019-01-11 22:08 ` Stephen Boyd
2019-01-10 1:12 ` [PATCH v3 5/6] ARM: dts: qcom: pm8941: add interrupt controller properties Brian Masney
2019-01-11 21:57 ` Stephen Boyd
2019-01-10 1:12 ` [PATCH v3 6/6] ARM: dts: qcom: pma8084: " Brian Masney
2019-01-11 21:57 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111230004.GA5805@basecamp \
--to=masneyb@onstation.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).