From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings Date: Tue, 15 Jan 2019 15:44:29 -0600 Message-ID: <20190115214429.GA21758@bogus> References: <20190111133133.24803-1-miquel.raynal@bootlin.com> <20190111133133.24803-7-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190111133133.24803-7-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Mathias Nyman , devicetree@vger.kernel.org, Antoine Tenart , Greg Kroah-Hartman , Gregory Clement , linux-usb@vger.kernel.org, Kishon Vijay Abraham I , Nadav Haklai , Alan Stern , Thomas Petazzoni , Maxime Chevallier , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On Fri, Jan 11, 2019 at 02:31:29PM +0100, Miquel Raynal wrote: > Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY. > > Signed-off-by: Miquel Raynal > --- > .../bindings/phy/phy-mvebu-utmi.txt | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt > new file mode 100644 > index 000000000000..4ade05ce5d51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt > @@ -0,0 +1,37 @@ > +MVEBU A3700 UTMI PHY > +-------------------- > + > +USB2 UTMI+ PHY controllers can be found on the following Marvell MVEBU SoCs: > +* Armada 3700 > + > +On Armada 3700, there are two USB controllers, one is compatible with the USB2 > +and USB3 specifications and supports OTG. The other one is USB2 compliant and > +only supports host mode. Both of these controllers come with a UTMI PHY. This paragraph says the controllers are different, but are the PHYs different? > + > +Required Properties: > + > +- compatible: Should be one of: > + * "marvell,a3700-utmi-host-phy" for the PHY connected to > + the USB2 host-only controller. > + * "marvell,a3700-utmi-otg-phy" for the PHY connected to > + the USB3 and USB2 OTG capable controller. > +- reg: PHY IP register range. > +- marvell,usb-misc-reg: handle on the "USB miscellaneous registers" shared > + region covering registers related to both the host > + controller and the PHY. > +- #phy-cells: Standard property (Documentation: phy-bindings.txt) Should be 0. > + > + > +Example: > + > + usb2_utmi_host_phy: phy@5f000 { > + compatible = "marvell,armada-3700-utmi-host-phy"; > + reg = <0x5f000 0x800>; > + marvell,usb-misc-reg = <&usb2_syscon>; > + #phy-cells = <0>; > + }; > + > + usb2_syscon: system-controller@5f800 { > + compatible = "syscon", "simple-mfd"; This is not valid because there's not a specific compatible string and 'simple-mfd' implies there are child nodes. > + reg = <0x5f800 0x800>; > + }; > -- > 2.19.1 >