From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [v2] arm64: dts: lx2160a: add sata node support Date: Wed, 16 Jan 2019 10:05:45 +0800 Message-ID: <20190116020543.GB15808@dragon> References: <20190114095500.1600-1-peng.ma@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190114095500.1600-1-peng.ma@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Peng Ma Cc: leoyang.li@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Mon, Jan 14, 2019 at 09:55:00AM +0000, Peng Ma wrote: > Add sata node support and Enable sata support I would suggest you reword the commit log like below: Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards. > > Signed-off-by: Peng Ma > --- > changed for V2: > - put the 'status' at the end of property list > - add lx2160aqds sata support > > arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16 +++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 16 +++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 44 +++++++++++++++++++++ > 3 files changed, 76 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > index 99a22ab..0289955 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > @@ -110,3 +110,19 @@ > &usb1 { > status = "okay"; > }; > + > +&sata0 { Please sort the labeling nodes alphabetically. Shawn > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 6481e5f..aacca27 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -117,3 +117,19 @@ > &usb1 { > status = "okay"; > }; > + > +&sata0 { > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index a79f5c1..4390aea 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -762,5 +762,49 @@ > ; > dma-coherent; > }; > + > + sata0: sata@3200000 { Please sort nodes with unit-address in order of the address. Shawn > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3200000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata1: sata@3210000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3210000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata2: sata@3220000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3220000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > + > + sata3: sata@3230000 { > + compatible = "fsl,lx2160a-ahci"; > + reg = <0x0 0x3230000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > + interrupts = ; > + clocks = <&clockgen 4 3>; > + dma-coherent; > + status = "disabled"; > + }; > }; > }; > -- > 1.7.1 >