From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property Date: Wed, 16 Jan 2019 22:44:11 -0800 Message-ID: <20190117064411.GK25498@builder> References: <1545039990-19984-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1545039990-19984-5-git-send-email-jorge.ramirez-ortiz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1545039990-19984-5-git-send-email-jorge.ramirez-ortiz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jorge Ramirez-Ortiz Cc: mark.rutland@arm.com, heiko@sntech.de, mturquette@baylibre.com, will.deacon@arm.com, david.brown@linaro.org, linux-clk@vger.kernel.org, jassisinghbrar@gmail.com, jagan@amarulasolutions.com, andy.gross@linaro.org, sibis@codeaurora.org, devicetree@vger.kernel.org, arnd@arndb.de, niklas.cassel@linaro.org, robh+dt@kernel.org, horms+renesas@verge.net.au, linux-arm-kernel@lists.infradead.org, olof@lixom.net, sboyd@kernel.org, linux-kernel@vger.kernel.org, amit.kucheria@linaro.org, vkoul@kernel.org, enric.balletbo@collabora.com, georgi.djakov@linaro.org List-Id: devicetree@vger.kernel.org On Mon 17 Dec 01:46 PST 2018, Jorge Ramirez-Ortiz wrote: > When the APCS clock is registered (platform dependent), it retrieves > its parent names from hardcoded values in the driver. > > The following commit allows the DT node to provide such clock names to > the platform data based clock driver therefore avoiding having to > explicitly embed those names in the clock driver source code. > > Co-developed-by: Niklas Cassel > Signed-off-by: Niklas Cassel > Signed-off-by: Jorge Ramirez-Ortiz > --- > .../bindings/mailbox/qcom,apcs-kpss-global.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt > index 1232fc9..f252439 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt > @@ -23,6 +23,10 @@ platforms. > Value type: > Definition: phandle to the input PLL, which feeds the APCS mux/divider > > + Usage: required if #clock-names property is present > + Value type: > + Definition: phandles to the two parent clocks of the clock driver. I presume you meant to replace the existing definition of "clocks"? I think the purpose of "required if #clock-cells" comes from that meaning that it represents a clock-controller if #clock-cells is specified, in which case it requires the upstream clock(s). Regards, Bjorn > + > - #mbox-cells: > Usage: required > Value type: > @@ -33,6 +37,12 @@ platforms. > Value type: > Definition: as described in clock.txt, must be 0 > > +- clock-names: > + Usage: required if the platform data based clock driver needs to > + retrieve the parent clock names from device tree. > + This will requires two mandatory clocks to be defined. > + Value type: > + Definition: must be "aux" and "pll" > > = EXAMPLE > The following example describes the APCS HMSS found in MSM8996 and part of the > @@ -65,3 +75,14 @@ Below is another example of the APCS binding on MSM8916 platforms: > clocks = <&a53pll>; > #clock-cells = <0>; > }; > + > +Below is another example of the APCS binding on QCS404 platforms: > + > + apcs_glb: mailbox@b011000 { > + compatible = "qcom,qcs404-apcs-apps-global", "syscon"; > + reg = <0x0b011000 0x1000>; > + #mbox-cells = <1>; > + clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>; > + clock-names = "aux", "pll"; > + #clock-cells = <0>; > + }; > -- > 2.7.4 >