From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers Date: Thu, 17 Jan 2019 14:22:18 -0800 Message-ID: <20190117222218.GF16918@Asurada-Nvidia.nvidia.com> References: <1547729177-14317-1-git-send-email-viorel.suman@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1547729177-14317-1-git-send-email-viorel.suman@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Viorel Suman Cc: Liam Girdwood , Mark Brown , Rob Herring , Mark Rutland , Jaroslav Kysela , Takashi Iwai , Timur Tabi , Xiubo Li , Fabio Estevam , "S.j. Wang" , Daniel Baluta , Cosmin Samoila , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , dl-linux-imx , Viorel Suman List-Id: devicetree@vger.kernel.org On Thu, Jan 17, 2019 at 12:46:25PM +0000, Viorel Suman wrote: > The patchset adds NXP Audio Mixer (AUDMIX) device and machine > drivers and related DT bindings documentation. > > Changes since V2: > 1. Moved "dais" node from machine driver DTS node to device driver DTS node > as suggested by Rob. Yea, it makes a lot of sense. Otherwise, since the connection between IP blocks is fixed inside the SoC, the virtual sound node would need to be put in the soc-level dtsi, which sounds odd to me. > Changes since V1: > 1. Original patch split into distinct patches for the device driver and > DT binding documentation. > 2. Replaced AMIX with AUDMIX in both code and file names as it looks more > RM-compliant. > 3. Removed polarity control from CPU DAI driver as suggested by Nicolin. > 4. Added machine driver and related DT binding documentation. > > Viorel Suman (4): > ASoC: fsl: Add Audio Mixer CPU DAI driver > ASoC: add fsl_audmix DT binding documentation > ASoC: fsl: Add Audio Mixer machine driver > ASoC: add imx-audmix DT binding documentation Reviewed-by: Nicolin Chen