From: Boris Brezillon <bbrezillon@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] memory: jz4780_nemc: Add support for the JZ4725B
Date: Fri, 18 Jan 2019 09:18:32 +0100 [thread overview]
Message-ID: <20190118091832.733b78f4@bbrezillon> (raw)
In-Reply-To: <20190117224550.18043-4-paul@crapouillou.net>
On Thu, 17 Jan 2019 19:45:50 -0300
Paul Cercueil <paul@crapouillou.net> wrote:
> Add support for the JZ4725B SoC from Ingenic.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
I don't know anything about the JZ4725B constraints but the code looks
good, so
Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
> ---
> drivers/memory/jz4780-nemc.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c
> index ef3f20e46590..c472a22d6df5 100644
> --- a/drivers/memory/jz4780-nemc.c
> +++ b/drivers/memory/jz4780-nemc.c
> @@ -44,9 +44,14 @@
> #define NEMC_NFCSR_NFCEn(n) BIT((((n) - 1) << 1) + 1)
> #define NEMC_NFCSR_TNFEn(n) BIT(16 + (n) - 1)
>
> +struct jz_soc_info {
> + u8 tas_tah_cycles_max;
> +};
> +
> struct jz4780_nemc {
> spinlock_t lock;
> struct device *dev;
> + const struct jz_soc_info *soc_info;
> void __iomem *base;
> struct clk *clk;
> uint32_t clk_period;
> @@ -202,7 +207,7 @@ static bool jz4780_nemc_configure_bank(struct jz4780_nemc *nemc,
> if (of_property_read_u32(node, "ingenic,nemc-tAS", &val) == 0) {
> smcr &= ~NEMC_SMCR_TAS_MASK;
> cycles = jz4780_nemc_ns_to_cycles(nemc, val);
> - if (cycles > 15) {
> + if (cycles > nemc->soc_info->tas_tah_cycles_max) {
> dev_err(nemc->dev, "tAS %u is too high (%u cycles)\n",
> val, cycles);
> return false;
> @@ -214,7 +219,7 @@ static bool jz4780_nemc_configure_bank(struct jz4780_nemc *nemc,
> if (of_property_read_u32(node, "ingenic,nemc-tAH", &val) == 0) {
> smcr &= ~NEMC_SMCR_TAH_MASK;
> cycles = jz4780_nemc_ns_to_cycles(nemc, val);
> - if (cycles > 15) {
> + if (cycles > nemc->soc_info->tas_tah_cycles_max) {
> dev_err(nemc->dev, "tAH %u is too high (%u cycles)\n",
> val, cycles);
> return false;
> @@ -278,6 +283,10 @@ static int jz4780_nemc_probe(struct platform_device *pdev)
> if (!nemc)
> return -ENOMEM;
>
> + nemc->soc_info = device_get_match_data(dev);
> + if (!nemc->soc_info)
> + return -EINVAL;
> +
> spin_lock_init(&nemc->lock);
> nemc->dev = dev;
>
> @@ -370,8 +379,17 @@ static int jz4780_nemc_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct jz_soc_info jz4725b_soc_info = {
> + .tas_tah_cycles_max = 7,
> +};
> +
> +static const struct jz_soc_info jz4780_soc_info = {
> + .tas_tah_cycles_max = 15,
> +};
> +
> static const struct of_device_id jz4780_nemc_dt_match[] = {
> - { .compatible = "ingenic,jz4780-nemc" },
> + { .compatible = "ingenic,jz4725b-nemc", .data = &jz4725b_soc_info, },
> + { .compatible = "ingenic,jz4780-nemc", .data = &jz4780_soc_info, },
> {},
> };
>
next prev parent reply other threads:[~2019-01-18 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 22:45 [PATCH 1/4] dt-bindings: memory: jz4780: Add compatible string for JZ4725B SoC Paul Cercueil
2019-01-17 22:45 ` [PATCH 2/4] memory: Kconfig: Drop dependency on MACH_JZ4780 for jz4780 Paul Cercueil
2019-01-18 8:09 ` Boris Brezillon
2019-01-17 22:45 ` [PATCH 3/4] memory: jz4780-nemc: Reduce size of const array Paul Cercueil
2019-01-18 8:15 ` Boris Brezillon
2019-01-18 14:10 ` Paul Cercueil
2019-01-17 22:45 ` [PATCH 4/4] memory: jz4780_nemc: Add support for the JZ4725B Paul Cercueil
2019-01-18 8:18 ` Boris Brezillon [this message]
2019-01-18 8:09 ` [PATCH 1/4] dt-bindings: memory: jz4780: Add compatible string for JZ4725B SoC Boris Brezillon
-- strict thread matches above, loose matches on Subject: below --
2018-08-22 17:29 [PATCH 1/4] dt-bindings: memory: jz4780-nemc: Add compatible string for JZ4725B Paul Cercueil
2018-08-22 17:29 ` [PATCH 4/4] memory: jz4780_nemc: Add support for the JZ4725B Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118091832.733b78f4@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).