From: Boris Brezillon <bbrezillon@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH 6/8] mtd: rawnand: jz4780-bch: Don't set clock rate in driver
Date: Fri, 18 Jan 2019 09:31:16 +0100 [thread overview]
Message-ID: <20190118093116.5f62efa5@bbrezillon> (raw)
In-Reply-To: <20190118010634.27399-6-paul@crapouillou.net>
On Thu, 17 Jan 2019 22:06:32 -0300
Paul Cercueil <paul@crapouillou.net> wrote:
> This should be done in devicetree. Besides, it prevents us from
> supporting other SoCs which don't use the same clock frequency for the
> BCH hardware.
As I said earlier, I disagree with this statement, plus, you're
breaking backward compat with existing DTs when doing that.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/mtd/nand/raw/jz4780_bch.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 7e4e5e627603..161d3821e1c4 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -57,8 +57,6 @@
> #define BCH_BHINT_UNCOR BIT(1)
> #define BCH_BHINT_ERR BIT(0)
>
> -#define BCH_CLK_RATE (200 * 1000 * 1000)
> -
> /* Timeout for BCH calculation/correction. */
> #define BCH_TIMEOUT_US 100000
>
> @@ -348,8 +346,6 @@ static int jz4780_bch_probe(struct platform_device *pdev)
> return PTR_ERR(bch->clk);
> }
>
> - clk_set_rate(bch->clk, BCH_CLK_RATE);
> -
> mutex_init(&bch->lock);
>
> bch->dev = dev;
next prev parent reply other threads:[~2019-01-18 8:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 1:06 [PATCH 1/8] MIPS: DTS: CI20: Set BCH clock to 200 MHz Paul Cercueil
2019-01-18 1:06 ` [PATCH 2/8] dt-bindings: mtd: ingenic: Add compatible strings for the JZ4725B Paul Cercueil
2019-01-18 8:20 ` Boris Brezillon
2019-01-18 1:06 ` [PATCH 3/8] mtd: rawnand: jz4780: Use SPDX license notifiers Paul Cercueil
2019-01-18 8:22 ` Boris Brezillon
2019-01-18 1:06 ` [PATCH 4/8] mtd: rawnand: jz4780: Add support for the JZ4725B Paul Cercueil
2019-01-18 8:26 ` Boris Brezillon
2019-01-18 1:06 ` [PATCH 5/8] mtd: rawnand: jz4780: Add ooblayout " Paul Cercueil
2019-01-18 8:29 ` Boris Brezillon
2019-01-18 1:06 ` [PATCH 6/8] mtd: rawnand: jz4780-bch: Don't set clock rate in driver Paul Cercueil
2019-01-18 8:31 ` Boris Brezillon [this message]
2019-01-18 1:06 ` [PATCH 7/8] mtd: rawnand: jz4780-bch: Separate top-level and SoC specific code Paul Cercueil
2019-01-18 8:35 ` Boris Brezillon
2019-01-18 14:22 ` Paul Cercueil
2019-01-18 1:06 ` [PATCH 8/8] mtd: rawnand: jz4780-bch: Add support for the JZ4725B Paul Cercueil
2019-01-18 8:07 ` [PATCH 1/8] MIPS: DTS: CI20: Set BCH clock to 200 MHz Boris Brezillon
2019-01-18 14:15 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118093116.5f62efa5@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=harveyhuntnexus@gmail.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).