From: Michael Tretter <m.tretter@pengutronix.de>
To: linux-media@vger.kernel.org, devicetree@vger.kernel.org
Cc: kernel@pengutronix.de, robh+dt@kernel.org, mchehab@kernel.org,
tfiga@chromium.org, Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH v2 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver
Date: Fri, 18 Jan 2019 14:37:13 +0100 [thread overview]
Message-ID: <20190118133716.29288-1-m.tretter@pengutronix.de> (raw)
This is v2 of the series to add support for the Allegro DVT H.264 encoder
found in the EV family of the Xilinx ZynqMP platform.
See v1 [0] of the patch series for a description of the hardware.
I fixed the handling of frames with various sizes and driver is now able to
encode H.264 video in the baseline profile up to 1920x1080 pixels. I also
addressed the issues reported by the kbuild robot for the previous series,
implemented a few extended controls and changed the interface to the mcu to
follow the register documentation rather than the downstream driver
implementation.
I would especially appreciate feedback to the device tree bindings and the
overall architecture of the driver.
The driver still only works with the vcu-firmware release 2018.2. I am not yet
sure how to address the different firmware versions, because in addition to
the mailbox sizes, there are also changes within the messages themselves.
I also did not address the integration with the xlnx-vcu driver, yet.
Michael
[0] https://lore.kernel.org/linux-media/20190109113037.28430-1-m.tretter@pengutronix.de/
Changes since v1:
- clean up debug log levels
- fix unused variable in allegro_mbox_init
- fix uninitialized variable in allegro_mbox_write
- fix global module parameters
- fix Kconfig dependencies
- return h264 as default codec for mcu
- implement device reset as documented
- document why irq does not wait for clear
- rename ENCODE_ONE_FRM to ENCODE_FRAME
- allow error codes for mcu_channel_id
- move control handler to channel
- add fw version check
- add support for colorspaces
- enable configuration of H.264 levels
- enable configuration of frame size
- enable configuration of bit rate and CPB size
- enable configuration of GOP size
- rework response handling
- fix missing error handling in allegro_h264_write_sps
Michael Tretter (3):
media: dt-bindings: media: document allegro-dvt bindings
[media] allegro: add Allegro DVT video IP core driver
[media] allegro: add SPS/PPS nal unit writer
.../devicetree/bindings/media/allegro.txt | 35 +
MAINTAINERS | 6 +
drivers/staging/media/Kconfig | 2 +
drivers/staging/media/Makefile | 1 +
drivers/staging/media/allegro-dvt/Kconfig | 16 +
drivers/staging/media/allegro-dvt/Makefile | 6 +
.../staging/media/allegro-dvt/allegro-core.c | 2828 +++++++++++++++++
drivers/staging/media/allegro-dvt/nal-h264.c | 1278 ++++++++
drivers/staging/media/allegro-dvt/nal-h264.h | 188 ++
9 files changed, 4360 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/allegro.txt
create mode 100644 drivers/staging/media/allegro-dvt/Kconfig
create mode 100644 drivers/staging/media/allegro-dvt/Makefile
create mode 100644 drivers/staging/media/allegro-dvt/allegro-core.c
create mode 100644 drivers/staging/media/allegro-dvt/nal-h264.c
create mode 100644 drivers/staging/media/allegro-dvt/nal-h264.h
--
2.20.1
next reply other threads:[~2019-01-18 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 13:37 Michael Tretter [this message]
2019-01-18 13:37 ` [PATCH v2 1/3] media: dt-bindings: media: document allegro-dvt bindings Michael Tretter
2019-01-21 10:59 ` Philipp Zabel
2019-01-21 16:17 ` Nicolas Dufresne
2019-01-21 16:30 ` Philipp Zabel
2019-01-21 17:42 ` Michael Tretter
2019-01-21 17:13 ` Rob Herring
2019-01-22 13:38 ` Michael Tretter
2019-01-18 13:37 ` [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver Michael Tretter
2019-01-23 10:44 ` Hans Verkuil
2019-01-23 14:17 ` Michael Tretter
2019-01-30 3:46 ` Nicolas Dufresne
2019-01-30 3:54 ` Tomasz Figa
2019-01-30 9:22 ` Michael Tretter
2019-01-30 3:41 ` Nicolas Dufresne
2019-01-30 7:47 ` Hans Verkuil
2019-01-30 15:19 ` Nicolas Dufresne
2019-01-30 16:14 ` Michael Tretter
2019-01-18 13:37 ` [PATCH v2 3/3] [media] allegro: add SPS/PPS nal unit writer Michael Tretter
2019-01-18 14:11 ` [PATCH v2 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver Hans Verkuil
2019-01-21 10:42 ` Michael Tretter
2019-01-23 10:48 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118133716.29288-1-m.tretter@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).