From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers Date: Fri, 18 Jan 2019 11:46:42 -0800 Message-ID: <20190118194642.GA11798@Asurada-Nvidia.nvidia.com> References: <1547729177-14317-1-git-send-email-viorel.suman@nxp.com> <20190117161804.GA5760@bogus> <1547817384.11482.33.camel@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1547817384.11482.33.camel@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Viorel Suman Cc: "robh@kernel.org" , dl-linux-imx , Cosmin Samoila , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "timur@kernel.org" , "devicetree@vger.kernel.org" , "Xiubo.Lee@gmail.com" , "viorel.suman@gmail.com" , Fabio Estevam , "broonie@kernel.org" , "mark.rutland@arm.com" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "S.j. Wang" , Daniel Baluta , "perex@perex.cz" , alsa- List-Id: devicetree@vger.kernel.org On Fri, Jan 18, 2019 at 01:16:24PM +0000, Viorel Suman wrote: > > > 1. Moved "dais" node from machine driver DTS node to device driver > > > DTS node > > >   as suggested by Rob. > > That was not what I suggested. You still have a virtual node which > > looks to me to be unnecessary. > > To me removing virtual node implies that AUDMIX machine driver (imx- > audmix.c + virtual node) shall be removed and machine driver code > merged into device driver (fsl_audmix.c + device node) - please let me > know if my understanding is wrong. We could use a non-DT configuration right? From the driver logic, DT just registers a device corresponding to the machine driver so that it can probe(). We could register one in fsl_audmix instead. Please refer to how fsl_ssi registers the sound card device. The machine driver can get audmix_np from the parent device pointer, and I think that's all you need. Or maybe someone else would provide a better way. But it'd work.