From: Rob Herring <robh@kernel.org>
To: Chanwoo Choi <cwchoi00@gmail.com>
Cc: Kamil Konieczny <k.konieczny@partner.samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-clk@vger.kernel.org, Chanwoo Choi <cw00.choi@samsung.com>,
devicetree <devicetree@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v4 4/5] dt-bindings: clk: exynos5433: add imem clock
Date: Mon, 21 Jan 2019 08:51:32 -0600 [thread overview]
Message-ID: <20190121145132.GA19195@bogus> (raw)
In-Reply-To: <CAGTfZH1K-f9kxVourd_-hfDoLXsjyrCL+5FLDycsR4kRG9mpGg@mail.gmail.com>
On Sat, Jan 19, 2019 at 09:40:10PM +0900, Chanwoo Choi wrote:
> Hi Kamil,
>
> This version only adds following two clocks without that other clocks
> be included in imem block.
> - CLK_ACLK_SLIMSSS
> - CLK_PCLK_SLIMSSS
>
> Usually, the users only refer to
> 'include/dt-bindings/clock/exynos5433.h' in order to get the supported
> clocks. It means that if there are different between the clock list in
> 'include/dt-bindings/clock/exynos5433.h' and the supported clock list
> of drivers/clock/', it make the confusion for users. So,
> 'include/dt-bindings/clock/exynos5433.h' have to define the only
> supported clock ids.
>
> Please remove other clock ids except for CLK_ACLK_SLIMSSS/CLK_PCLK_SLIMSSS.
And add clocks 1-by-1 instead? The binding headers are a pain to merge
because they are a dts and driver dependency. Having a complete header
is preferred unless there is doubt in the correctness of it.
The driver can warn users about unsupported IDs.
Rob
next prev parent reply other threads:[~2019-01-21 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190118131710eucas1p1b4d7f67c5aa2832b669b1f3cff0235aa@eucas1p1.samsung.com>
2019-01-18 13:16 ` [PATCH v4 0/5] Add imem clock for Exynos 5433 Kamil Konieczny
2019-01-18 13:16 ` [PATCH v4 1/5] clk: samsung: exynos5433: fix typo in imem divider Kamil Konieczny
2019-01-18 13:16 ` [PATCH v4 2/5] clk: samsung: exynos5433: fix name typo in sssx Kamil Konieczny
2019-01-18 13:16 ` [PATCH v4 3/5] dt-bindings: clk: exynos5433: document imem clock Kamil Konieczny
2019-01-18 13:16 ` [PATCH v4 4/5] dt-bindings: clk: exynos5433: add " Kamil Konieczny
2019-01-19 12:40 ` Chanwoo Choi
2019-01-21 14:51 ` Rob Herring [this message]
2019-01-22 0:27 ` Chanwoo Choi
2019-01-22 9:41 ` Sylwester Nawrocki
2019-01-21 14:52 ` Rob Herring
2019-01-18 13:16 ` [PATCH v4 5/5] clk: samsung: exynos5433: add imem clocks Kamil Konieczny
2019-01-19 12:41 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121145132.GA19195@bogus \
--to=robh@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=k.konieczny@partner.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).