From: Tony Lindgren <tony@atomide.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Arthur Demchenkov <spinal.by@gmail.com>,
bcousson@baylibre.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-omap@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity
Date: Mon, 21 Jan 2019 12:00:30 -0800 [thread overview]
Message-ID: <20190121200030.GJ5544@atomide.com> (raw)
In-Reply-To: <CAOMZO5DDM5=ZL8_-JZpX23ChoKhuBY7-bNaTE7JjDW0jwsHb4A@mail.gmail.com>
* Fabio Estevam <festevam@gmail.com> [190121 17:52]:
> On Mon, Jan 21, 2019 at 5:43 AM Arthur Demchenkov <spinal.by@gmail.com> wrote:
> >
> > Wrong polarity of card detect GPIO pin leads to the system not
> > booting from external mmc, if the back cover of N900 is closed.
> > When the cover is open the system boots fine.
> >
> > This wasn't noticed before, because of a bug, which was fixed
> > by commit e63201f19 (mmc: omap_hsmmc: Delete platform data GPIO
> > CD and WP).
> >
> > Kernels up to 4.19 ignored the card detect GPIO from DT.
>
> Signed-off-by tag is missing.
Arthur, please reply with your Signed-off-by for this
thread so I can apply it. That is unless you want to
repost the patch for updated comments etc.
Regards,
Tony
next prev parent reply other threads:[~2019-01-21 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 3:21 [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity Arthur Demchenkov
2019-01-21 17:11 ` Tony Lindgren
2019-01-21 19:45 ` Aaro Koskinen
2019-01-21 17:52 ` Fabio Estevam
2019-01-21 20:00 ` Tony Lindgren [this message]
2019-01-22 4:59 ` Arthur D.
2019-01-22 22:56 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121200030.GJ5544@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=spinal.by@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).