Re: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support

[Rob Herring <robh@kernel.org>]

On Fri, Jan 11, 2019 at 11:56:00AM +0000, Aisheng Dong wrote:
> Add imx8qm scu clock support
> 
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 5ec6dca..b6a883e 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
>  
>  Required properties:
>  - compatible:		Should be one of:
> -			  "fsl,imx8qxp-clock"
> +			  "fsl,imx8qm-clock",
> +			  "fsl,imx8qxp-clock".

No need for the punctuation here. The whole point of one per line is to 
have 1 line changes. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

>  			followed by "fsl,scu-clk"
>  - #clock-cells:		Should be 1. Contains the Clock ID value.
>  - clocks:		List of clock specifiers, must contain an entry for
> -- 
> 2.7.4
>