From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Date: Tue, 22 Jan 2019 11:00:12 +0800 Message-ID: <20190122030011.GC19233@dragon> References: <20190114102053.16013-1-manivannan.sadhasivam@linaro.org> <20190114102053.16013-3-manivannan.sadhasivam@linaro.org> <20190116022100.GC15808@dragon> <20190116101441.GH15808@dragon> <20190121060950.GA8713@Mani-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Leo Li Cc: Manivannan Sadhasivam , Rob Herring , "devicetree@vger.kernel.org" , "a.tropschug@ebs-systart.com" , "m.bittner@ebs-systart.com" , "linux-kernel@vger.kernel.org" , Amit Kucheria , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org On Mon, Jan 21, 2019 at 07:57:20PM +0000, Leo Li wrote: > > > So it seems the compatible of the boards below are missing there. > > > > > > ls1021a-moxa-uc-8410a.dts > > > ls1021a-qds.dts > > > ls1021a-twr.dts > > > > So how should we proceed here? The above mentioned boards are lacking > > compatible in dts files and I guess that's the reason they didn't get > > mentioned in "fsl" binding file. > > > > Should I just go ahead and add the compatibles for these boards and list > > them in binding file? > > Please go ahead and do that. One thing is that the moxa-uc-8410a board is a 3rd-party board, not sure if it should belong to the fsl binding file. The fsl.yaml is designed to contain various boards using fsl SoCs, so it's fine. Shawn