From: Thierry Reding <thierry.reding@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, mperttunen@nvidia.com,
chunyan.zhang@unisoc.com, jonathanh@nvidia.com,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
anrao@nvidia.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH V10 4/4] mmc: tegra: HW Command Queue Support for Tegra SDMMC
Date: Wed, 23 Jan 2019 10:20:12 +0100 [thread overview]
Message-ID: <20190123092012.GC24072@ulmo> (raw)
In-Reply-To: <1548186993-6229-4-git-send-email-skomatineni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
On Tue, Jan 22, 2019 at 11:56:33AM -0800, Sowjanya Komatineni wrote:
> This patch adds HW Command Queue for supported Tegra SDMMC
> controllers.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> [V10]: Changes are same as V9 except this series has SDHCI core changes
> into seperate patch
>
> drivers/mmc/host/Kconfig | 1 +
> drivers/mmc/host/sdhci-tegra.c | 117 +++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 114 insertions(+), 4 deletions(-)
Sowjanya,
it's good practice to collect the various tags that you've received on
patches when resending. I had already acked patches 1 and 3 of v9, so
you should've added the Acked-by for at least this patch 4/4 because it
is unchanged from v9. The Acked-by on patch 1 was also valid because you
only moved the documentation, but it is otherwise unchanged.
No worries, though, just something to keep in mind when you send v11
with the typofix that Adrian pointed out.
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-23 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 19:56 [PATCH V10 1/4] dt-bindings: mmc: Add supports-cqe property Sowjanya Komatineni
2019-01-22 19:56 ` [PATCH V10 2/4] arm64: dts: tegra: Add CQE Support for SDMMC4 Sowjanya Komatineni
2019-01-22 19:56 ` [PATCH V10 3/4] mmc: sdhci: Add ADMA3 DMA support for V4 enabled host Sowjanya Komatineni
2019-01-23 7:27 ` Adrian Hunter
2019-01-23 9:15 ` Thierry Reding
2019-01-22 19:56 ` [PATCH V10 4/4] mmc: tegra: HW Command Queue Support for Tegra SDMMC Sowjanya Komatineni
2019-01-23 7:28 ` Adrian Hunter
2019-01-23 9:20 ` Thierry Reding [this message]
2019-01-23 9:15 ` [PATCH V10 1/4] dt-bindings: mmc: Add supports-cqe property Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123092012.GC24072@ulmo \
--to=thierry.reding@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=anrao@nvidia.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).