From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Moon Subject: [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy Date: Wed, 23 Jan 2019 15:12:08 +0000 Message-ID: <20190123151209.2080-3-linux.amoon@gmail.com> References: <20190123151209.2080-1-linux.amoon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190123151209.2080-1-linux.amoon@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Kishon Vijay Abraham I , Rob Herring , Jerome Brunet List-Id: devicetree@vger.kernel.org This patch enables the USB Host controller (USB0) and the relative USB0 PHY. >>From the shematics GPIOAO.BIT5 gpio input for the PWREN signal of the USB_OTG controller (usb0) which is also linked to USB_HOST controller (usb1). Add missing phy-supply link to both USB0 and USB1 phy controller This changes fixed the power issue on usb ports. Changes help fix usb reset warning. [ 821.991470] usb 1-1.2: reset high-speed USB device number 3 using dwc2 [ 825.243385] usb 1-1.2: reset high-speed USB device number 3 using dwc2 [ 828.151310] usb 1-1.2: reset high-speed USB device number 3 using dwc2 [ 830.991241] usb 1-1.2: reset high-speed USB device number 3 using dwc2 Fixes: 2eb79a4d15ff ("ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board") Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil Armstrong Cc: Kevin Hilman Signed-off-by: Anand Moon --- Changes from previous patch. Fix the subject and commit message as per Martin's request --Add the signal name in the comment --Replace vbus-supply with phy-supply linking the power supply to phy node as pointed by Marine which a PWREN signal in the USB_HOST controller (usb1) USB_VBUS 4 2 0 unknown 5000mV 0mA 5000mV 5000mV phy-c1108820.phy.1 2 0mA 0mV 0mV phy-c1108800.phy.0 2 0mA 0mV 0mV --- arch/arm/boot/dts/meson8b-odroidc1.dts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index 58669abda259..bfa472a679d9 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -83,6 +83,22 @@ regulator-max-microvolt = <5000000>; }; + usb_vbus: regulator-usb-vbus { + compatible = "regulator-fixed"; + + regulator-name = "USB_VBUS"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + + vin-supply = <&p5v0>; + + /* + * signal name from schematics: PWREN + */ + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + tflash_vdd: regulator-tflash_vdd { /* * signal name from schematics: TFLASH_VDD_EN @@ -295,8 +311,18 @@ pinctrl-names = "default"; }; +&usb0_phy { + status = "okay"; + phy-supply = <&usb_vbus>; +}; + &usb1_phy { status = "okay"; + phy-supply = <&usb_vbus>; +}; + +&usb0 { + status = "okay"; }; &usb1 { -- 2.20.1