From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Moon Subject: [RFCv1 3/3] ARM: dts: meson8b: odroidc1: enable the OTG capable USB controller Date: Wed, 23 Jan 2019 15:12:09 +0000 Message-ID: <20190123151209.2080-4-linux.amoon@gmail.com> References: <20190123151209.2080-1-linux.amoon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190123151209.2080-1-linux.amoon@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Kishon Vijay Abraham I , Rob Herring , Jerome Brunet List-Id: devicetree@vger.kernel.org Override the dr_mode from "host" to "otg" for USB_HOST controller (usb0) changes help usb_phy0->usb0 initialization of OTG bus port. Changes fix the below warning. [ 1.810267] phy phy-c1108800.phy.0: USB ID detect failed! [ 1.814333] phy phy-c1108800.phy.0: phy poweron failed --> -22 [ 1.820178] ------------[ cut here ]------------ [ 1.824758] WARNING: CPU: 0 PID: 29 at drivers/regulator/core.c:2054 _regulator_put.part.8+0xf8/0xfc [ 1.833884] Modules linked in: [ 1.836907] CPU: 0 PID: 29 Comm: kworker/0:1 Not tainted 5.0.0-rc3-xc1ml #1 [ 1.843849] Hardware name: Amlogic Meson platform [ 1.848552] Workqueue: events deferred_probe_work_func [ 1.853683] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 1.861404] [] (show_stack) from [] (dump_stack+0x8c/0xa0) [ 1.868610] [] (dump_stack) from [] (__warn.part.3+0xbc/0xd8) [ 1.876074] [] (__warn.part.3) from [] (warn_slowpath_null+0x44/0x4c) [ 1.884236] [] (warn_slowpath_null) from [] (_regulator_put.part.8+0xf8/0xfc) [ 1.893093] [] (_regulator_put.part.8) from [] (regulator_put+0x28/0x38) [ 1.901516] [] (regulator_put) from [] (regulator_bulk_free+0x28/0x38) [ 1.909770] [] (regulator_bulk_free) from [] (release_nodes+0x1bc/0x200) [ 1.918191] [] (release_nodes) from [] (really_probe+0x110/0x2cc) [ 1.926005] [] (really_probe) from [] (driver_probe_device+0x60/0x16c) [ 1.934256] [] (driver_probe_device) from [] (bus_for_each_drv+0x80/0xc4) [ 1.942766] [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x138) [ 1.951015] [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [ 1.959180] [] (bus_probe_device) from [] (deferred_probe_work_func+0x60/0x8c) [ 1.968127] [] (deferred_probe_work_func) from [] (process_one_work+0x218/0x504) [ 1.977243] [] (process_one_work) from [] (worker_thread+0x2a8/0x5bc) [ 1.985404] [] (worker_thread) from [] (kthread+0x14c/0x154) [ 1.992785] [] (kthread) from [] (ret_from_fork+0x14/0x2c) [ 1.999987] Exception stack(0xee0dbfb0 to 0xee0dbff8) [ 2.005027] bfa0: 00000000 00000000 00000000 00000000 [ 2.013191] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 2.021353] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 2.027984] ---[ end trace 81270e5c573fd4b5 ]--- [ 2.032661] ------------[ cut here ]------------ [ 2.037162] WARNING: CPU: 0 PID: 29 at drivers/regulator/core.c:2054 _regulator_put.part.8+0xf8/0xfc [ 2.046296] Modules linked in: [ 2.049331] CPU: 0 PID: 29 Comm: kworker/0:1 Tainted: G W 5.0.0-rc3-xc1ml #1 [ 2.057647] Hardware name: Amlogic Meson platform [ 2.062344] Workqueue: events deferred_probe_work_func [ 2.067471] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 2.075197] [] (show_stack) from [] (dump_stack+0x8c/0xa0) [ 2.082405] [] (dump_stack) from [] (__warn.part.3+0xbc/0xd8) [ 2.089871] [] (__warn.part.3) from [] (warn_slowpath_null+0x44/0x4c) [ 2.098034] [] (warn_slowpath_null) from [] (_regulator_put.part.8+0xf8/0xfc) [ 2.106891] [] (_regulator_put.part.8) from [] (regulator_put+0x28/0x38) [ 2.115314] [] (regulator_put) from [] (regulator_bulk_free+0x28/0x38) [ 2.123566] [] (regulator_bulk_free) from [] (release_nodes+0x1bc/0x200) [ 2.131988] [] (release_nodes) from [] (really_probe+0x110/0x2cc) [ 2.139802] [] (really_probe) from [] (driver_probe_device+0x60/0x16c) [ 2.148054] [] (driver_probe_device) from [] (bus_for_each_drv+0x80/0xc4) [ 2.156564] [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x138) [ 2.164813] [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [ 2.172978] [] (bus_probe_device) from [] (deferred_probe_work_func+0x60/0x8c) [ 2.181923] [] (deferred_probe_work_func) from [] (process_one_work+0x218/0x504) [ 2.191040] [] (process_one_work) from [] (worker_thread+0x2a8/0x5bc) [ 2.199201] [] (worker_thread) from [] (kthread+0x14c/0x154) [ 2.206582] [] (kthread) from [] (ret_from_fork+0x14/0x2c) [ 2.213785] Exception stack(0xee0dbfb0 to 0xee0dbff8) [ 2.218824] bfa0: 00000000 00000000 00000000 00000000 [ 2.226989] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 2.235151] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 2.241774] ---[ end trace 81270e5c573fd4b6 ]--- [ 2.246415] dwc2: probe of c9040000.usb failed with error -22 Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil Armstrong Cc: Kevin Hilman Signed-off-by: Anand Moon --- Changes from previous patch. Fix the subject and commit message as per Martin's request --Fix the commit message. --TODO: allthough the bus port is initialization, but their is not usb device detected on the otg port. --- arch/arm/boot/dts/meson8b-odroidc1.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index bfa472a679d9..a41912039522 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -323,6 +323,7 @@ &usb0 { status = "okay"; + dr_mode = "otg"; }; &usb1 { -- 2.20.1