* [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor
@ 2019-01-24 17:52 Jagan Teki
2019-01-25 8:40 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Jagan Teki @ 2019-01-24 17:52 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland
Cc: Michael Trimarchi, linux-amarula, devicetree, linux-kernel,
Jagan Teki
Amarula A64 Relic has STLM75 sensor for digital temperature
and thermal watchdog.
Add support for it.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Note: the respective driver change is already in mainline
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2e9a41bbc1079776dabe42ed8113b086b99ae56c
.../dts/allwinner/sun50i-a64-amarula-relic.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
index 6cb2b7f0c817..5d942543d978 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
@@ -34,6 +34,21 @@
status = "okay";
};
+&i2c0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0_pins>;
+ status = "okay";
+
+ temp@48 {
+ compatible = "st,stlm75";
+ reg = <0x48>;
+ };
+};
+
+&i2c0_pins {
+ bias-pull-up;
+};
+
&mmc1 {
pinctrl-names = "default";
pinctrl-0 = <&mmc1_pins>;
--
2.18.0.321.gffc6fa0e3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor
2019-01-24 17:52 [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor Jagan Teki
@ 2019-01-25 8:40 ` Maxime Ripard
2019-01-28 7:16 ` Jagan Teki
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2019-01-25 8:40 UTC (permalink / raw)
To: Jagan Teki
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Michael Trimarchi,
linux-amarula, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On Thu, Jan 24, 2019 at 11:22:54PM +0530, Jagan Teki wrote:
> Amarula A64 Relic has STLM75 sensor for digital temperature
> and thermal watchdog.
>
> Add support for it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Note: the respective driver change is already in mainline
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2e9a41bbc1079776dabe42ed8113b086b99ae56c
>
> .../dts/allwinner/sun50i-a64-amarula-relic.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> index 6cb2b7f0c817..5d942543d978 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> @@ -34,6 +34,21 @@
> status = "okay";
> };
>
> +&i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins>;
> + status = "okay";
> +
> + temp@48 {
That would be sensor@48
> + compatible = "st,stlm75";
That compatible isn't documented.
The rest looks good, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor
2019-01-25 8:40 ` Maxime Ripard
@ 2019-01-28 7:16 ` Jagan Teki
2019-01-28 12:33 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Jagan Teki @ 2019-01-28 7:16 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Michael Trimarchi,
linux-amarula, devicetree, linux-kernel
On Fri, Jan 25, 2019 at 2:10 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Thu, Jan 24, 2019 at 11:22:54PM +0530, Jagan Teki wrote:
> > Amarula A64 Relic has STLM75 sensor for digital temperature
> > and thermal watchdog.
> >
> > Add support for it.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Note: the respective driver change is already in mainline
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2e9a41bbc1079776dabe42ed8113b086b99ae56c
> >
> > .../dts/allwinner/sun50i-a64-amarula-relic.dts | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > index 6cb2b7f0c817..5d942543d978 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > @@ -34,6 +34,21 @@
> > status = "okay";
> > };
> >
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins>;
> > + status = "okay";
> > +
> > + temp@48 {
>
> That would be sensor@48
>
> > + compatible = "st,stlm75";
>
> That compatible isn't documented.
True, but none of the compatible strings used on the driver doesn't
documented in binding instead there are documented in
Documentation/hwmon/lm75.
Don't know the exact reason, do we need to document this in binding as well?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor
2019-01-28 7:16 ` Jagan Teki
@ 2019-01-28 12:33 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-01-28 12:33 UTC (permalink / raw)
To: Jagan Teki
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Michael Trimarchi,
linux-amarula, devicetree, linux-kernel
On Mon, Jan 28, 2019 at 12:46:48PM +0530, Jagan Teki wrote:
> On Fri, Jan 25, 2019 at 2:10 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > On Thu, Jan 24, 2019 at 11:22:54PM +0530, Jagan Teki wrote:
> > > Amarula A64 Relic has STLM75 sensor for digital temperature
> > > and thermal watchdog.
> > >
> > > Add support for it.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Note: the respective driver change is already in mainline
> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2e9a41bbc1079776dabe42ed8113b086b99ae56c
> > >
> > > .../dts/allwinner/sun50i-a64-amarula-relic.dts | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > > index 6cb2b7f0c817..5d942543d978 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > > @@ -34,6 +34,21 @@
> > > status = "okay";
> > > };
> > >
> > > +&i2c0 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&i2c0_pins>;
> > > + status = "okay";
> > > +
> > > + temp@48 {
> >
> > That would be sensor@48
> >
> > > + compatible = "st,stlm75";
> >
> > That compatible isn't documented.
>
> True, but none of the compatible strings used on the driver doesn't
> documented in binding instead there are documented in
> Documentation/hwmon/lm75.
It doesn't look like a DT binding documentation.
> Don't know the exact reason, do we need to document this in binding
> as well?
Yep
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-28 12:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 17:52 [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor Jagan Teki
2019-01-25 8:40 ` Maxime Ripard
2019-01-28 7:16 ` Jagan Teki
2019-01-28 12:33 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).