From: Niklas Cassel <niklas.cassel@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: qcs404: Add AR8035 Phy node
Date: Thu, 24 Jan 2019 23:06:29 +0100 [thread overview]
Message-ID: <20190124220629.GA23971@centauri.lan> (raw)
In-Reply-To: <20190123174839.5321-3-vkoul@kernel.org>
On Wed, Jan 23, 2019 at 11:18:39PM +0530, Vinod Koul wrote:
> EVB-4000 has ethernet port with AR8035 Phy, so add phy node
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts
> index 5c02e874be12..ec85647cfed1 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts
> @@ -21,6 +21,17 @@
> pinctrl-names = "default";
> pinctrl-0 = <ðernet_defaults>;
>
> + phy-handle = <&phy1>;
> + phy-mode = "rgmii";
> + mdio {
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> + compatible = "snps,dwmac-mdio";
> + phy1: phy@4 {
Hello Vinod,
The AR8035 PHY is compliant with IEEE802.3u clause 22, so please add:
compatible = "ethernet-phy-ieee802.3-c22";
Also, please squash this commit with PATCH 2/3.
The previous patch sets status = "ok" without having a PHY defined,
but I also don't see any reason to keep 2/3 and 3/3 as separate patches.
Kind regards,
Niklas
> + device_type = "ethernet-phy";
> + reg = <0x4>;
> + };
> + };
> };
>
> &tlmm {
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-24 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:48 [PATCH 1/3] arm64: dts: qcom: qcs404: Add Ethernet node Vinod Koul
2019-01-23 17:48 ` [PATCH 2/3] arm64: dts: qcom: qcs404: Enable ethernet for EVB-4000 Vinod Koul
2019-01-23 17:48 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Add AR8035 Phy node Vinod Koul
2019-01-24 22:06 ` Niklas Cassel [this message]
2019-01-28 4:12 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124220629.GA23971@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).