From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
Mathias Nyman <mathias.nyman@intel.com>,
devicetree@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-usb@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
Nadav Haklai <nadavh@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 04/10] usb: ehci-orion: add S2RAM support
Date: Fri, 25 Jan 2019 11:35:38 +0100 [thread overview]
Message-ID: <20190125113538.24d5ca02@xps13> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1901231456060.1564-100000@iolanthe.rowland.org>
Hi Alan,
Alan Stern <stern@rowland.harvard.edu> wrote on Wed, 23 Jan 2019
14:58:44 -0500 (EST):
> On Mon, 21 Jan 2019, Miquel Raynal wrote:
>
> > Add suspend/resume callbacks to reset the host controller properly
> > during S2RAM operation.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/usb/host/ehci-orion.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> > index 3109f082949e..dab22aa57c0b 100644
> > --- a/drivers/usb/host/ehci-orion.c
> > +++ b/drivers/usb/host/ehci-orion.c
> > @@ -182,6 +182,30 @@ static int ehci_orion_drv_reset(struct usb_hcd *hcd)
> > return ret;
> > }
> >
> > +static int __maybe_unused ehci_orion_drv_suspend(struct device *dev)
> > +{
> > + struct usb_hcd *hcd = dev_get_drvdata(dev);
> > + struct ehci_hcd *ehci = hcd_to_ehci(hcd);
> > +
> > + ehci_prepare_ports_for_controller_suspend(ehci,
> > + device_may_wakeup(dev));
> > +
> > + return ehci_suspend(hcd, false);
>
> This is a little odd. Why not just call
>
> ehci_suspend(hcd, device_may_wakeup(dev));
>
> directly and let it take care of calling
> ehci_prepare_ports_for_controller_suspend() for you? If you have a
> good reason for doing things this way, please mention that reason in
> the Changelog.
There is no reason, I think I got the inspiration from an other driver
calling manually ehci_prepare_ports_for_controller_suspend(), but I did
not check it was already taken care of by ehci_suspend/resume().
Call removed in both paths, thanks!
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-25 10:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 11:23 [PATCH v3 00/10] A3700 USB S2RAM support Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 01/10] usb: core: comply to PHY framework Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 02/10] usb: host: xhci: mvebu: add reset on resume quirk Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 03/10] usb: ehci-orion: avoid double PHY initialization Miquel Raynal
2019-01-23 20:01 ` Alan Stern
2019-01-21 11:23 ` [PATCH v3 04/10] usb: ehci-orion: add S2RAM support Miquel Raynal
2019-01-23 19:58 ` Alan Stern
2019-01-25 10:35 ` Miquel Raynal [this message]
2019-01-21 11:23 ` [PATCH v3 05/10] phy: add A3700 UTMI PHY driver Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings Miquel Raynal
2019-01-21 15:44 ` Rob Herring
2019-01-21 15:47 ` Gregory CLEMENT
2019-01-22 16:08 ` Rob Herring
2019-01-22 16:13 ` Miquel Raynal
2019-01-22 17:38 ` Thomas Petazzoni
2019-01-22 19:16 ` Miquel Raynal
2019-01-23 13:51 ` Thomas Petazzoni
2019-01-21 11:23 ` [PATCH v3 07/10] MAINTAINERS: phy: fill Armada 3700 PHY drivers entry Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 08/10] ARM64: dts: marvell: armada-37xx: fix USB2 memory region Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 09/10] ARM64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs Miquel Raynal
2019-01-21 11:23 ` [PATCH v3 10/10] ARM64: dts: marvell: armada-37xx: link USB hosts with their PHYs Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125113538.24d5ca02@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).