From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Sebastian Reichel" <sre@kernel.org>
Subject: Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
Date: Fri, 25 Jan 2019 17:28:14 +0100 [thread overview]
Message-ID: <20190125162814.GA7571@amd> (raw)
In-Reply-To: <20190107175907.45268-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
Hi!
> We're now getting the following error:
>
> genirq: Setting trigger mode 1 for irq 230 failed
> (regmap_irq_set_type+0x0/0x15c)
> cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
>
> This is because of a typo in the irq flags. Really these interrupts
> are LEVEL, but before we change them we need to test them. So let's
> do a minimal fix first.
Could we get this one applied? It is regression fix for 5.0-rc1...
Pavel
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> --- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> +++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi
> @@ -105,7 +105,7 @@
> interrupts-extended = <
> &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
> &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
> - &cpcap 48 1
> + &cpcap 48 0
> >;
> interrupt-names =
> "id_ground", "id_float", "se0conn", "vbusvld",
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-01-25 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 17:59 [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Tony Lindgren
2019-01-07 18:37 ` Rob Herring
2019-01-07 18:45 ` Tony Lindgren
2019-01-07 18:45 ` Pavel Machek
2019-01-25 16:28 ` Pavel Machek [this message]
2019-01-25 16:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125162814.GA7571@amd \
--to=pavel@ucw.cz \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).