From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v3 2/4] ASoC: add fsl_audmix DT binding documentation Date: Fri, 25 Jan 2019 17:49:19 -0800 Message-ID: <20190126014918.GA2617@Asurada-Nvidia.nvidia.com> References: <1547729177-14317-1-git-send-email-viorel.suman@nxp.com> <1547729177-14317-3-git-send-email-viorel.suman@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1547729177-14317-3-git-send-email-viorel.suman@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Viorel Suman , Rob Herring Cc: Liam Girdwood , Mark Brown , Mark Rutland , Jaroslav Kysela , Takashi Iwai , Timur Tabi , Xiubo Li , Fabio Estevam , "S.j. Wang" , Daniel Baluta , Cosmin Samoila , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , dl-linux-imx , Viorel Suman List-Id: devicetree@vger.kernel.org On Thu, Jan 17, 2019 at 12:46:29PM +0000, Viorel Suman wrote: > + - dais : Must contain a list of phandles to AUDMIX connected > + DAIs. The current implementation requires two phandles > + to SAI interfaces to be provided, the first SAI in the > + list being used to route the AUDMIX output. Another small thing, that I just noticed, is this list. It forces the first input source to be the output source without giving any chance. I feel that we could have some flexibility here: one node for two input sources, and one node for the output source. Well, there is no critical problem with the current binding since it follows the SoC design. Yet I doubt if this routing logic will never break. Any suggestion, Rob?