From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 26 Jan 2019 20:19:58 +0000 From: Jonathan Cameron Subject: Re: [PATCH v2 4/6] dt-bindings: document open-drain property Message-ID: <20190126201958.0448e660@archlinux> In-Reply-To: <20190122020431.5338-4-martin@martingkelly.com> References: <20190122020431.5338-1-martin@martingkelly.com> <20190122020431.5338-4-martin@martingkelly.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Martin Kelly Cc: linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Daniel Baluta , devicetree@vger.kernel.orgRobHerringrobh+dt@kernel.org List-ID: On Mon, 21 Jan 2019 18:04:29 -0800 Martin Kelly wrote: > From: Martin Kelly > > We have added an optional boolean property for configuring a BMI160 > interrupt pin as open-drain, as opposed to the default push-pull, so > document this. > > Signed-off-by: Martin Kelly > --- > Documentation/devicetree/bindings/iio/imu/bmi160.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/bmi160.txt b/Documentation/devicetree/bindings/iio/imu/bmi160.txt > index 1aec19997fb5..7eb4b6016404 100644 > --- a/Documentation/devicetree/bindings/iio/imu/bmi160.txt > +++ b/Documentation/devicetree/bindings/iio/imu/bmi160.txt > @@ -12,6 +12,8 @@ Optional properties: > - interrupts : interrupt mapping for IRQ > - interrupt-names : set to "INT1" if INT1 pin should be used as interrupt > input, set to "INT2" if INT2 pin should be used instead > +- bmi160,open-drain : set if the specified interrupt pin should be configured as > + open drain. If not set, defaults to push-pull. I missed this before, but normally we prefix with a manufacturer rather than a particular part number. Maybe that changed when I wasn't looking though! Anyhow, these DT binding changes all need devicetree maintainer reviews as they aren't totally trivial. Thanks, Jonathan > > Examples: >