From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] ARM: dts: sun5i: q8-tablet: Move panel properties to correct node level
Date: Sun, 27 Jan 2019 22:48:35 +0800 [thread overview]
Message-ID: <20190127144838.3578-3-wens@csie.org> (raw)
In-Reply-To: <20190127144838.3578-1-wens@csie.org>
The panel backlight and enable GPIO comments were incorrectly placed
in the input port, while it should have been in the panel node itself.
Move them to the correct position.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm/boot/dts/sun5i-a13-q8-tablet.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts b/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts
index a89f29fa3e40..3a844dae26f7 100644
--- a/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts
+++ b/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts
@@ -50,13 +50,13 @@
panel: panel {
compatible = "urt,umsh-8596md-t", "simple-panel";
+ /* TODO: lcd panel uses axp gpio0 as enable pin */
+ backlight = <&backlight>;
#address-cells = <1>;
#size-cells = <0>;
port@0 {
reg = <0>;
- /* TODO: lcd panel uses axp gpio0 as enable pin */
- backlight = <&backlight>;
#address-cells = <1>;
#size-cells = <0>;
--
2.20.1
next prev parent reply other threads:[~2019-01-27 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 14:48 [PATCH 0/5] ARM: dts: sun5i: q8-tablet: Complete LCD panel description Chen-Yu Tsai
2019-01-27 14:48 ` [PATCH 1/5] ARM: dts: sun5i: Add backlight GPIO for reference design tablet Chen-Yu Tsai
2019-01-28 10:51 ` Maxime Ripard
2019-01-27 14:48 ` Chen-Yu Tsai [this message]
2019-01-28 10:52 ` [PATCH 2/5] ARM: dts: sun5i: q8-tablet: Move panel properties to correct node level Maxime Ripard
2019-01-27 14:48 ` [PATCH 3/5] ARM: dts: sun5i: q8-tablet: Add LCD Panel enable GPIO Chen-Yu Tsai
2019-01-28 10:52 ` Maxime Ripard
2019-01-27 14:48 ` [PATCH 4/5] ARM: dts: sun5i: q8-tablet: Add LCD Panel power supply Chen-Yu Tsai
2019-01-28 10:53 ` Maxime Ripard
2019-01-27 14:48 ` [PATCH 5/5] ARM: dts: sun5i: q8-tablet: Use bananapi,s070wv20-ct16 panel compatible Chen-Yu Tsai
2019-01-28 10:53 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127144838.3578-3-wens@csie.org \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).