From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Kemnade Subject: Re: [PATCH] arm: dts: gta04: add gps support Date: Mon, 28 Jan 2019 17:44:29 +0100 Message-ID: <20190128163025.7daa385b@kemnade.info> References: <20190125194310.11170-1-andreas@kemnade.info> <20190128075356.GJ3691@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/jnd3g4.rS3VPk9X7AQnelhT"; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190128075356.GJ3691@localhost> Sender: linux-kernel-owner@vger.kernel.org To: Johan Hovold Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org List-Id: devicetree@vger.kernel.org --Sig_/jnd3g4.rS3VPk9X7AQnelhT Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 28 Jan 2019 08:53:56 +0100 Johan Hovold wrote: > On Fri, Jan 25, 2019 at 08:43:10PM +0100, Andreas Kemnade wrote: > > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable > > which one is mounted so use the compatibility entry for w2sg0004 > > for all which will work for both. > >=20 > > Signed-off-by: Andreas Kemnade > > --- > > w2sg0004 bindings (together with the corresponding support is in > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/gnss gnss-next) > > arch/arm/boot/dts/omap3-gta04.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/oma= p3-gta04.dtsi > > index e53d32691308..d58c117e429f 100644 > > --- a/arch/arm/boot/dts/omap3-gta04.dtsi > > +++ b/arch/arm/boot/dts/omap3-gta04.dtsi > > @@ -312,6 +312,12 @@ =20 > > >; =20 > > }; > > =20 > > + gps_pins: pinmux_gps_pins { > > + pinctrl-single,pins =3D < > > + OMAP3_CORE1_IOPAD(0x2176, PIN_OUTPUT_PULLDOWN | MUX_MODE4) /* gpio1= 45 */ > > + >; > > + }; > > + > > hdq_pins: hdq_pins { > > pinctrl-single,pins =3D < > > OMAP3_CORE1_IOPAD(0x21c6, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c3_sda= .hdq */ > > @@ -644,6 +650,13 @@ > > &uart2 { > > pinctrl-names =3D "default"; > > pinctrl-0 =3D <&uart2_pins>; > > + gps: gps { =20 >=20 > The node should be named "gnss" as per the binding. >=20 > > + compatible =3D "wi2wi,w2sg0004"; > > + pinctrl-names =3D "default"; > > + pinctrl-0 =3D <&gps_pins>; > > + sirf,onoff-gpios =3D <&gpio5 17 GPIO_ACTIVE_HIGH>; > > + lna-supply =3D <&vsim>; =20 >=20 > Also, the vcc-supply is a required property. >=20 well, it is not require in the driver and it has different behavior (on eve= n when not opened if on-off is there) than the lna-supply used here. So maybe fix the binding do= cumentation? Regards, Andreas --Sig_/jnd3g4.rS3VPk9X7AQnelhT Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAlxPMW0ACgkQl4jFM1s/ ye9ZoQ//VDB79MrCEDDdmoQ81Yg/OoS+lifHW5tNqOVyNrMNVaOxBwLU6K58X7w6 2eCBj79lc4EDxhanbw5b2dczCyi5HdaeOPPkQu3exYonnXAw1j9+tAEEz6howJXu 9c/FOO4AsiUuyIqbMtHg+Vu93ydGhWuA2xG4PBwwIXdacLUTtkL7MRQfQadUpHt+ w4cBm+BR0AsWJQETP2Y0qu8XfRTUJ1tXyO96UUt3USzPOW58LhY6Dw3llBaLActc vkKRa8yr1NppxwBqixnSpXI6AG1l0MuQnSQhsF0D3J1TbYnLbYDpyeitMBbe1Vmf Cr0kA7VKVJ0chSCVZOuFBhGmbG6cgwxFK91tu/Fo6ZjIMXCfzyY7PFjPAqevpp4a skkEZMiCL6WdHabKVGRJiFnCOOXEEq/RZguXNhvUF9GHTlFP0vWtz6+ozgc6gNWv 97C/02Oo49qkTnrJHvhBdZ05iq7TD8hlurjSnwq2c1rk4CSIWVD6nkkgI+Nii87D 4Fr20DUhcyJtyDE0h0MP4fXvLTrMsPuRM4dY+y6LCR8uwaFBNv5mB+DmUxfS/gJ6 IvUWEtgJ94jc6e4a2W3gc6L0jQS7TiMedlwIN0/Ebyrekt1tWHyvZEahHzcWrY7U dWH1kNyNG3QyFB6AHUfqlkri5z7zpYNsmHScTtjaXTM0ZKCgE+Q= =r8SB -----END PGP SIGNATURE----- --Sig_/jnd3g4.rS3VPk9X7AQnelhT--