From: Leo Yan <leo.yan@linaro.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Tingwei Zhang <tingwei@codeaurora.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Doug Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Brown <david.brown@linaro.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sibi Sankar <sibis@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCHv5 6/7] coresight: debug: Add Unique Component Identifier (UCI) table
Date: Tue, 29 Jan 2019 21:36:05 +0800 [thread overview]
Message-ID: <20190129133605.GB16669@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20190129132528.GA16669@leoy-ThinkPad-X240s>
On Tue, Jan 29, 2019 at 09:25:28PM +0800, Leo Yan wrote:
> On Tue, Jan 29, 2019 at 12:44:03AM +0530, Sai Prakash Ranjan wrote:
> > Add UCI table and a helper macro for coresight CPU debug
> > module. This patch adds the UCI entries for Krypo CPUs
> > found on MSM8996 which shares the same PIDs as ETMs.
> >
> > Without this, below error is observed on MSM8996:
> >
> > [ 5.429867] OF: graph: no port node found in /soc/debug@3810000
> > [ 5.429938] coresight-etm4x: probe of 3810000.debug failed with error -22
> > [ 5.435415] coresight-cpu-debug 3810000.debug: Coresight debug-CPU0 initialized
> > [ 5.446474] OF: graph: no port node found in /soc/debug@3910000
> > [ 5.448927] coresight-etm4x: probe of 3910000.debug failed with error -22
> > [ 5.454681] coresight-cpu-debug 3910000.debug: Coresight debug-CPU1 initialized
> > [ 5.487765] OF: graph: no port node found in /soc/debug@3a10000
> > [ 5.488007] coresight-etm4x: probe of 3a10000.debug failed with error -22
> > [ 5.493024] coresight-cpu-debug 3a10000.debug: Coresight debug-CPU2 initialized
> > [ 5.501802] OF: graph: no port node found in /soc/debug@3b10000
> > [ 5.512901] coresight-etm4x: probe of 3b10000.debug failed with error -22
> > [ 5.513192] coresight-cpu-debug 3b10000.debug: Coresight debug-CPU3 initialized
> >
> > Also add a helper macro to make adding CPU PIDs easier
> > similar to ETM4X driver.
> >
> > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>
> Looks good to me and tested on my Hikey board (though I cannot test
> for a device with UCI ID):
>
> Reviewed-and-tested-by: Leo Yan <leo.yan@linaro.org>
I just now found if apply this patch onto coresight next branch [1],
it will conflict with patch 'coresight: cpu-debug: Support for CA73
CPUs' [2]. Sorry if introduce regression by this.
Hi Mathieu, could you confirm should apply this patch onto to coresight
next branch?
[...]
Thanks,
Leo Yan
[1] https://git.linaro.org/kernel/coresight.git/log/?h=next
[2] https://git.linaro.org/kernel/coresight.git/commit/?h=next&id=14420b405d03cd160b5ace283693ce5b1cf273fa
next prev parent reply other threads:[~2019-01-29 13:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 19:13 [PATCHv5 0/7] Add coresight support for SDM845, MSM8998 and MSM8996 Sai Prakash Ranjan
2019-01-28 19:13 ` [PATCHv5 1/7] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan
2019-01-30 18:37 ` Mathieu Poirier
2019-01-31 13:16 ` Sai Prakash Ranjan
2019-01-28 19:13 ` [PATCHv5 2/7] arm64: dts: qcom: msm8998: " Sai Prakash Ranjan
2019-01-28 19:14 ` [PATCHv5 3/7] arm64: dts: qcom: msm8996: " Sai Prakash Ranjan
2019-01-28 19:14 ` [PATCHv5 4/7] coresight: etm4x: Add support to enable ETMv4.2 Sai Prakash Ranjan
2019-01-29 9:26 ` Suzuki K Poulose
2019-01-29 14:46 ` Sai Prakash Ranjan
2019-01-28 19:14 ` [PATCHv5 5/7] coresight: etm4x: Add ETM PIDs for SDM845 and MSM8996 Sai Prakash Ranjan
2019-01-29 9:28 ` Suzuki K Poulose
2019-01-28 19:14 ` [PATCHv5 6/7] coresight: debug: Add Unique Component Identifier (UCI) table Sai Prakash Ranjan
2019-01-29 13:25 ` Leo Yan
2019-01-29 13:36 ` Leo Yan [this message]
2019-01-29 14:54 ` Sai Prakash Ranjan
2019-01-29 14:48 ` Sai Prakash Ranjan
2019-01-28 19:14 ` [PATCHv5 7/7] arm64: dts: qcom: sdm845: Remove the duplicate header inclusion Sai Prakash Ranjan
2019-01-28 19:24 ` Doug Anderson
2019-01-29 4:35 ` saiprakash.ranjan
2019-01-29 10:28 ` [PATCHv5 0/7] Add coresight support for SDM845, MSM8998 and MSM8996 Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129133605.GB16669@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox