From: Vladimir Zapolskiy <vz@mleia.com>
To: Sylvain Lemieux <slemieux.tyco@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/13] ARM: lpc32xx: remove platform data of ARM PL111 LCD controller
Date: Tue, 29 Jan 2019 21:20:49 +0200 [thread overview]
Message-ID: <20190129192049.11223-14-vz@mleia.com> (raw)
In-Reply-To: <20190129192049.11223-1-vz@mleia.com>
The auxilary platform data added for the LCD controller is not needed
anymore, because the controller and a connected panel are properly
described in Phytec phyCORE-LPC3250 board dts file.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
arch/arm/mach-lpc32xx/phy3250.c | 77 ---------------------------------
1 file changed, 77 deletions(-)
diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
index 568589e918c2..b3be60a8e467 100644
--- a/arch/arm/mach-lpc32xx/phy3250.c
+++ b/arch/arm/mach-lpc32xx/phy3250.c
@@ -45,73 +45,6 @@
#include <mach/board.h>
#include "common.h"
-/*
- * AMBA LCD controller
- */
-static struct clcd_panel conn_lcd_panel = {
- .mode = {
- .name = "QVGA portrait",
- .refresh = 60,
- .xres = 240,
- .yres = 320,
- .pixclock = 191828,
- .left_margin = 22,
- .right_margin = 11,
- .upper_margin = 2,
- .lower_margin = 1,
- .hsync_len = 5,
- .vsync_len = 2,
- .sync = 0,
- .vmode = FB_VMODE_NONINTERLACED,
- },
- .width = -1,
- .height = -1,
- .tim2 = (TIM2_IVS | TIM2_IHS),
- .cntl = (CNTL_BGR | CNTL_LCDTFT | CNTL_LCDVCOMP(1) |
- CNTL_LCDBPP16_565),
- .bpp = 16,
-};
-#define PANEL_SIZE (3 * SZ_64K)
-
-static int lpc32xx_clcd_setup(struct clcd_fb *fb)
-{
- dma_addr_t dma;
-
- fb->fb.screen_base = dma_alloc_wc(&fb->dev->dev, PANEL_SIZE, &dma,
- GFP_KERNEL);
- if (!fb->fb.screen_base) {
- printk(KERN_ERR "CLCD: unable to map framebuffer\n");
- return -ENOMEM;
- }
-
- fb->fb.fix.smem_start = dma;
- fb->fb.fix.smem_len = PANEL_SIZE;
- fb->panel = &conn_lcd_panel;
-
- return 0;
-}
-
-static int lpc32xx_clcd_mmap(struct clcd_fb *fb, struct vm_area_struct *vma)
-{
- return dma_mmap_wc(&fb->dev->dev, vma, fb->fb.screen_base,
- fb->fb.fix.smem_start, fb->fb.fix.smem_len);
-}
-
-static void lpc32xx_clcd_remove(struct clcd_fb *fb)
-{
- dma_free_wc(&fb->dev->dev, fb->fb.fix.smem_len, fb->fb.screen_base,
- fb->fb.fix.smem_start);
-}
-
-static struct clcd_board lpc32xx_clcd_data = {
- .name = "Phytec LCD",
- .check = clcdfb_check,
- .decode = clcdfb_decode,
- .setup = lpc32xx_clcd_setup,
- .mmap = lpc32xx_clcd_mmap,
- .remove = lpc32xx_clcd_remove,
-};
-
static struct pl08x_channel_data pl08x_slave_channels[] = {
{
.bus_id = "nand-slc",
@@ -159,7 +92,6 @@ static struct lpc32xx_mlc_platform_data lpc32xx_mlc_data = {
static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA("arm,pl022", 0x20084000, "dev:ssp0", NULL),
OF_DEV_AUXDATA("arm,pl022", 0x2008C000, "dev:ssp1", NULL),
- OF_DEV_AUXDATA("arm,pl110", 0x31040000, "dev:clcd", &lpc32xx_clcd_data),
OF_DEV_AUXDATA("arm,pl080", 0x31000000, "pl08xdmac", &pl08x_pd),
OF_DEV_AUXDATA("nxp,lpc3220-slc", 0x20020000, "20020000.flash",
&lpc32xx_slc_data),
@@ -170,15 +102,6 @@ static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = {
static void __init lpc3250_machine_init(void)
{
- u32 tmp;
-
- /* Setup LCD muxing to RGB565 */
- tmp = __raw_readl(LPC32XX_CLKPWR_LCDCLK_CTRL) &
- ~(LPC32XX_CLKPWR_LCDCTRL_LCDTYPE_MSK |
- LPC32XX_CLKPWR_LCDCTRL_PSCALE_MSK);
- tmp |= LPC32XX_CLKPWR_LCDCTRL_LCDTYPE_TFT16;
- __raw_writel(tmp, LPC32XX_CLKPWR_LCDCLK_CTRL);
-
lpc32xx_serial_init();
/* Test clock needed for UDA1380 initial init */
--
2.20.1
prev parent reply other threads:[~2019-01-29 19:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 19:20 [PATCH 00/13] ARM: lpc32xx: various minor fixes and clean-ups Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 01/13] ARM: defconfig: lpc32xx: enable fixed voltage regulator support Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 02/13] ARM: defconfig: lpc32xx: enable DRM simple panel driver Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 03/13] ARM: dts: lpc32xx: fix ARM PrimeCell LCD controller variant Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 04/13] ARM: dts: lpc32xx: fix ARM PrimeCell LCD controller clocks property Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 05/13] ARM: dts: lpc32xx: phy3250: fix SD card regulator voltage Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 06/13] ARM: dts: lpc32xx: remove inclusion of deprecated skeleton.dtsi Vladimir Zapolskiy
2019-01-30 20:33 ` Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 07/13] ARM: dts: lpc32xx: phy3250: remove regulators umbrella device node Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 08/13] ARM: dts: lpc32xx: phy3250: setup LCD controller to panel interface Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 09/13] ARM: dts: lpc32xx: phy3250: add unit address to memory device node Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 10/13] ARM: dts: lpc32xx: ea3250: " Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 11/13] ARM: dts: lpc32xx: ea3250: beautify gpio keys children nodes Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 12/13] ARM: lpc32xx: remove platform data of ARM PL180 SD/MMC controller Vladimir Zapolskiy
2019-01-29 19:20 ` Vladimir Zapolskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129192049.11223-14-vz@mleia.com \
--to=vz@mleia.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=slemieux.tyco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).