From: Vladimir Zapolskiy <vz@mleia.com>
To: Sylvain Lemieux <slemieux.tyco@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/13] ARM: dts: lpc32xx: phy3250: remove regulators umbrella device node
Date: Tue, 29 Jan 2019 21:20:43 +0200 [thread overview]
Message-ID: <20190129192049.11223-8-vz@mleia.com> (raw)
In-Reply-To: <20190129192049.11223-1-vz@mleia.com>
The originally added 'regulators' device node has a number of flaws,
to name a few its children has unit addresses but no reg properties,
the regulators are not captured by a device driver due to a missing
'simple-bus' compatible, the regulator names are selected by killing
either alphabetical order or device node grouping property.
The change removes 'regulators' device node and renames the regulators
and labels.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
arch/arm/boot/dts/lpc3250-phy3250.dts | 63 +++++++++++++--------------
1 file changed, 31 insertions(+), 32 deletions(-)
diff --git a/arch/arm/boot/dts/lpc3250-phy3250.dts b/arch/arm/boot/dts/lpc3250-phy3250.dts
index ffcf78631b22..d2dad2b541ff 100644
--- a/arch/arm/boot/dts/lpc3250-phy3250.dts
+++ b/arch/arm/boot/dts/lpc3250-phy3250.dts
@@ -25,37 +25,6 @@
reg = <0x80000000 0x4000000>;
};
- regulators {
- backlight_reg: regulator@0 {
- compatible = "regulator-fixed";
- regulator-name = "backlight_reg";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- gpio = <&gpio 5 4 0>;
- enable-active-high;
- regulator-boot-on;
- };
-
- lcd_reg: regulator@1 {
- compatible = "regulator-fixed";
- regulator-name = "lcd_reg";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- gpio = <&gpio 5 0 0>;
- enable-active-high;
- regulator-boot-on;
- };
-
- sd_reg: regulator@2 {
- compatible = "regulator-fixed";
- regulator-name = "sd_reg";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- gpio = <&gpio 5 5 0>;
- enable-active-high;
- };
- };
-
leds {
compatible = "gpio-leds";
@@ -69,6 +38,36 @@
linux,default-trigger = "heartbeat";
};
};
+
+ reg_backlight: regulator-backlight {
+ compatible = "regulator-fixed";
+ regulator-name = "backlight";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ gpio = <&gpio 5 4 0>;
+ enable-active-high;
+ regulator-boot-on;
+ };
+
+ reg_lcd: regulator-lcd {
+ compatible = "regulator-fixed";
+ regulator-name = "lcd";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ gpio = <&gpio 5 0 0>;
+ enable-active-high;
+ regulator-boot-on;
+ };
+
+ reg_sd: regulator-sd {
+ compatible = "regulator-fixed";
+ regulator-name = "sd";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio 5 5 0>;
+ enable-active-high;
+ regulator-boot-on;
+ };
};
&clcd {
@@ -130,7 +129,7 @@
cd-gpios = <&gpio 3 1 0>;
cd-inverted;
bus-width = <4>;
- vmmc-supply = <&sd_reg>;
+ vmmc-supply = <®_sd>;
status = "okay";
};
--
2.20.1
next prev parent reply other threads:[~2019-01-29 19:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 19:20 [PATCH 00/13] ARM: lpc32xx: various minor fixes and clean-ups Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 01/13] ARM: defconfig: lpc32xx: enable fixed voltage regulator support Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 02/13] ARM: defconfig: lpc32xx: enable DRM simple panel driver Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 03/13] ARM: dts: lpc32xx: fix ARM PrimeCell LCD controller variant Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 04/13] ARM: dts: lpc32xx: fix ARM PrimeCell LCD controller clocks property Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 05/13] ARM: dts: lpc32xx: phy3250: fix SD card regulator voltage Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 06/13] ARM: dts: lpc32xx: remove inclusion of deprecated skeleton.dtsi Vladimir Zapolskiy
2019-01-30 20:33 ` Vladimir Zapolskiy
2019-01-29 19:20 ` Vladimir Zapolskiy [this message]
2019-01-29 19:20 ` [PATCH 08/13] ARM: dts: lpc32xx: phy3250: setup LCD controller to panel interface Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 09/13] ARM: dts: lpc32xx: phy3250: add unit address to memory device node Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 10/13] ARM: dts: lpc32xx: ea3250: " Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 11/13] ARM: dts: lpc32xx: ea3250: beautify gpio keys children nodes Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 12/13] ARM: lpc32xx: remove platform data of ARM PL180 SD/MMC controller Vladimir Zapolskiy
2019-01-29 19:20 ` [PATCH 13/13] ARM: lpc32xx: remove platform data of ARM PL111 LCD controller Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129192049.11223-8-vz@mleia.com \
--to=vz@mleia.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=slemieux.tyco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).