From: Andreas Kemnade <andreas@kemnade.info>
To: Johan Hovold <johan@kernel.org>
Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v2] arm: dts: gta04: add gps support
Date: Thu, 31 Jan 2019 17:41:03 +0100 [thread overview]
Message-ID: <20190131174015.544a00f3@kemnade.info> (raw)
In-Reply-To: <20190130090434.GM3691@localhost>
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
On Wed, 30 Jan 2019 10:04:34 +0100
Johan Hovold <johan@kernel.org> wrote:
> On Tue, Jan 29, 2019 at 08:38:43AM +0100, Andreas Kemnade wrote:
> > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable
> > which one is mounted so use the compatibility entry for w2sg0004
> > for all which will work for both.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > Changes in v2:
> > - some s/gps/gnss/
> > - not added vcc-supply because the regulator is not modelled
> > in dts at all
>
> I strongly suggest not sending revised patches before people have a
> chance to comment on your previous version and resolve any issues that
> may have been raised.
for technical check there was already some small team review ahead,
so I expect only formality issues and not something complicated and
was not mentally prepared for more discussion.
At that point I had the impression that I am not allowed to have
such driverless things into dtb, so I had the impression that I have
to follow two conflicting rules at the same time.
That leads to the impression that I worked a long way into a dead end
which made me quite angry so I was not as contructive as I should be.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-01-31 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 7:38 [PATCH v2] arm: dts: gta04: add gps support Andreas Kemnade
2019-01-30 9:04 ` Johan Hovold
2019-01-31 16:41 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131174015.544a00f3@kemnade.info \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).