* [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT
@ 2018-12-19 23:55 Matthias Kaehlcke
[not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw)
To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross,
David Brown
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Archit Taneja, Sean Paul, Rajesh Yadav, Douglas Anderson,
Stephen Boyd, Jeykumar Sankaran, Matthias Kaehlcke
The MSM DSI PHY drivers currently hardcode the name and the rate of
the PHY ref clock. Get the ref clock from the device tree instead.
Note: testing of this series was limited to SDM845 and the 10nm PHY
Major changes in v5:
- none (see per-patch change log for minor changes)
Major changes in v4:
- always use parent rate for 28nm and 28nm 8960 PHYs
Major changes in v3:
- keep supporting DTs without ref clock for the 28nm and the 28nm
8960 PHYs
- added patch to add ref clock to qcom-apq8064.dtsi
Major changes in v2:
- apply to all MSM DSI PHY drivers, not only 10nm
Matthias Kaehlcke (8):
dt-bindings: msm/dsi: Add ref clock for PHYs
drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT
drm/msm/dsi: 28nm PHY: Get ref clock from the DT
drm/msm/dsi: 14nm PHY: Get ref clock from the DT
drm/msm/dsi: 10nm PHY: Get ref clock from the DT
arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY
arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs
ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY
.../devicetree/bindings/display/msm/dsi.txt | 1 +
arch/arm/boot/dts/qcom-apq8064.dtsi | 5 +--
arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 +--
arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++---
drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 20 +++++++++--
drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c | 23 +++++++++---
drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c | 36 +++++++++++++------
.../gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c | 24 ++++++++++---
8 files changed, 92 insertions(+), 32 deletions(-)
--
2.20.1.415.g653613c723-goog
^ permalink raw reply [flat|nested] 13+ messages in thread[parent not found: <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]
* [PATCH v5 1/8] dt-bindings: msm/dsi: Add ref clock for PHYs [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> @ 2018-12-19 23:55 ` Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 2/8] drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT Matthias Kaehlcke ` (4 subsequent siblings) 5 siblings, 0 replies; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, Rob Herring, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, Stephen Boyd, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Allow the PHY drivers to get the ref clock from the DT. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes in v5: - added "Reviewed-by: Rob Herring <robh@kernel.org>" tag Changes in v4: - added "Reviewed-by" tags from Stephen and Doug Changes in v3: - added note that the ref clock is only required for new DTS files/entries Changes in v2: - add the ref clock for all PHYs, not only the 10nm one - updated commit message --- Documentation/devicetree/bindings/display/msm/dsi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt index dfc743219bd88..9ae9469427207 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi.txt +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt @@ -106,6 +106,7 @@ Required properties: - clocks: Phandles to device clocks. See [1] for details on clock bindings. - clock-names: the following clocks are required: * "iface" + * "ref" (only required for new DTS files/entries) For 28nm HPM/LP, 28nm 8960 PHYs: - vddio-supply: phandle to vdd-io regulator device node For 20nm PHY: -- 2.20.1.415.g653613c723-goog _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 2/8] drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-12-19 23:55 ` [PATCH v5 1/8] dt-bindings: msm/dsi: Add ref clock for PHYs Matthias Kaehlcke @ 2018-12-19 23:55 ` Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 3/8] drm/msm/dsi: 28nm " Matthias Kaehlcke ` (3 subsequent siblings) 5 siblings, 0 replies; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, Stephen Boyd, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> --- Changes in v5: - added "Reviewed-by: Stephen Boyd <swboyd@chromium.org>" tag Changes in v4: - always use parent rate in dsi_pll_28nm_clk_set_rate() - pass name of VCO ref clock to pll_28nm_register() instead of storing it in a struct field - updated commit message Changes in v3: - use default name and rate if the ref clock is not specified in the DT - store vco_ref_clk_name instead of vco_ref_clk - fixed check for EPROBE_DEFER - renamed VCO_REF_CLK_RATE to VCO_REF_CLK_DEFAULT_RATE Changes in v2: - patch added to the series --- .../gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c | 24 +++++++++++++++---- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c index 49008451085b8..76e5188169b91 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c @@ -47,7 +47,6 @@ #define NUM_PROVIDED_CLKS 2 -#define VCO_REF_CLK_RATE 27000000 #define VCO_MIN_RATE 600000000 #define VCO_MAX_RATE 1200000000 @@ -125,7 +124,7 @@ static int dsi_pll_28nm_clk_set_rate(struct clk_hw *hw, unsigned long rate, DBG("rate=%lu, parent's=%lu", rate, parent_rate); temp = rate / 10; - val = VCO_REF_CLK_RATE / 10; + val = parent_rate / 10; fb_divider = (temp * VCO_PREF_DIV_RATIO) / val; fb_divider = fb_divider / 2 - 1; pll_write(base + REG_DSI_28nm_8960_PHY_PLL_CTRL_1, @@ -406,11 +405,12 @@ static void dsi_pll_28nm_destroy(struct msm_dsi_pll *pll) pll_28nm->clks, pll_28nm->num_clks); } -static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm) +static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, + const char *ref_clk_name) { char *clk_name, *parent_name, *vco_name; struct clk_init_data vco_init = { - .parent_names = (const char *[]){ "pxo" }, + .parent_names = &ref_clk_name, .num_parents = 1, .flags = CLK_IGNORE_UNUSED, .ops = &clk_ops_dsi_pll_28nm_vco, @@ -494,6 +494,8 @@ struct msm_dsi_pll *msm_dsi_pll_28nm_8960_init(struct platform_device *pdev, { struct dsi_pll_28nm *pll_28nm; struct msm_dsi_pll *pll; + struct clk *vco_ref_clk; + const char *vco_ref_clk_name; int ret; if (!pdev) @@ -506,6 +508,18 @@ struct msm_dsi_pll *msm_dsi_pll_28nm_8960_init(struct platform_device *pdev, pll_28nm->pdev = pdev; pll_28nm->id = id + 1; + vco_ref_clk = devm_clk_get(&pdev->dev, "ref"); + if (!IS_ERR(vco_ref_clk)) { + vco_ref_clk_name = __clk_get_name(vco_ref_clk); + } else { + ret = PTR_ERR(vco_ref_clk); + if (ret == -EPROBE_DEFER) + return ERR_PTR(ret); + + dev_warn(&pdev->dev, "'ref' clock is not specified, using default name\n"); + vco_ref_clk_name = "pxo"; + } + pll_28nm->mmio = msm_ioremap(pdev, "dsi_pll", "DSI_PLL"); if (IS_ERR_OR_NULL(pll_28nm->mmio)) { dev_err(&pdev->dev, "%s: failed to map pll base\n", __func__); @@ -524,7 +538,7 @@ struct msm_dsi_pll *msm_dsi_pll_28nm_8960_init(struct platform_device *pdev, pll->en_seq_cnt = 1; pll->enable_seqs[0] = dsi_pll_28nm_enable_seq; - ret = pll_28nm_register(pll_28nm); + ret = pll_28nm_register(pll_28nm, vco_ref_clk_name); if (ret) { dev_err(&pdev->dev, "failed to register PLL: %d\n", ret); return ERR_PTR(ret); -- 2.20.1.415.g653613c723-goog _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 3/8] drm/msm/dsi: 28nm PHY: Get ref clock from the DT [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-12-19 23:55 ` [PATCH v5 1/8] dt-bindings: msm/dsi: Add ref clock for PHYs Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 2/8] drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT Matthias Kaehlcke @ 2018-12-19 23:55 ` Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 6/8] arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke ` (2 subsequent siblings) 5 siblings, 0 replies; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, Stephen Boyd, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> tag --- Changes in v5: - added missing return keyword in msm_dsi_pll_28nm_init() - added "Reviewed-by: Stephen Boyd <swboyd@chromium.org>" tag Changes in v4: - always use parent rate in dsi_pll_28nm_clk_set_rate() and dsi_pll_28nm_clk_recalc_rate() - pass name of VCO ref clock to pll_28nm_register() instead of storing it in a struct field - updated commit message Changes in v3: - use default name and rate if the ref clock is not specified in the DT - store vco_ref_clk_name instead of vco_ref_clk - dsi_pll_28nm_clk_set_rate: changed data type of ref_clk_rate to unsigned long - fixed check for EPROBE_DEFER - renamed VCO_REF_CLK_RATE to VCO_REF_CLK_DEFAULT_RATE Changes in v2: - patch added to the series --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c | 36 +++++++++++++++------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c index 26e3a01a99c2b..c839464741927 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c @@ -40,7 +40,6 @@ #define NUM_PROVIDED_CLKS 2 -#define VCO_REF_CLK_RATE 19200000 #define VCO_MIN_RATE 350000000 #define VCO_MAX_RATE 750000000 @@ -166,17 +165,17 @@ static int dsi_pll_28nm_clk_set_rate(struct clk_hw *hw, unsigned long rate, pll_write(base + REG_DSI_28nm_PHY_PLL_LPFC1_CFG, 0x70); pll_write(base + REG_DSI_28nm_PHY_PLL_LPFC2_CFG, 0x15); - rem = rate % VCO_REF_CLK_RATE; + rem = rate % parent_rate; if (rem) { refclk_cfg = DSI_28nm_PHY_PLL_REFCLK_CFG_DBLR; frac_n_mode = 1; - div_fbx1000 = rate / (VCO_REF_CLK_RATE / 500); - gen_vco_clk = div_fbx1000 * (VCO_REF_CLK_RATE / 500); + div_fbx1000 = rate / (parent_rate / 500); + gen_vco_clk = div_fbx1000 * (parent_rate / 500); } else { refclk_cfg = 0x0; frac_n_mode = 0; - div_fbx1000 = rate / (VCO_REF_CLK_RATE / 1000); - gen_vco_clk = div_fbx1000 * (VCO_REF_CLK_RATE / 1000); + div_fbx1000 = rate / (parent_rate / 1000); + gen_vco_clk = div_fbx1000 * (parent_rate / 1000); } DBG("refclk_cfg = %d", refclk_cfg); @@ -265,7 +264,7 @@ static unsigned long dsi_pll_28nm_clk_recalc_rate(struct clk_hw *hw, void __iomem *base = pll_28nm->mmio; u32 sdm0, doubler, sdm_byp_div; u32 sdm_dc_off, sdm_freq_seed, sdm2, sdm3; - u32 ref_clk = VCO_REF_CLK_RATE; + u32 ref_clk = parent_rate; unsigned long vco_rate; VERB("parent_rate=%lu", parent_rate); @@ -273,7 +272,7 @@ static unsigned long dsi_pll_28nm_clk_recalc_rate(struct clk_hw *hw, /* Check to see if the ref clk doubler is enabled */ doubler = pll_read(base + REG_DSI_28nm_PHY_PLL_REFCLK_CFG) & DSI_28nm_PHY_PLL_REFCLK_CFG_DBLR; - ref_clk += (doubler * VCO_REF_CLK_RATE); + ref_clk += (doubler * ref_clk); /* see if it is integer mode or sdm mode */ sdm0 = pll_read(base + REG_DSI_28nm_PHY_PLL_SDM_CFG0); @@ -514,11 +513,12 @@ static void dsi_pll_28nm_destroy(struct msm_dsi_pll *pll) pll_28nm->clk_data.clk_num = 0; } -static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm) +static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, + const char *ref_clk_name) { char clk_name[32], parent1[32], parent2[32], vco_name[32]; struct clk_init_data vco_init = { - .parent_names = (const char *[]){ "xo" }, + .parent_names = &ref_clk_name, .num_parents = 1, .name = vco_name, .flags = CLK_IGNORE_UNUSED, @@ -593,6 +593,8 @@ struct msm_dsi_pll *msm_dsi_pll_28nm_init(struct platform_device *pdev, { struct dsi_pll_28nm *pll_28nm; struct msm_dsi_pll *pll; + struct clk *vco_ref_clk; + const char *vco_ref_clk_name; int ret; if (!pdev) @@ -605,6 +607,18 @@ struct msm_dsi_pll *msm_dsi_pll_28nm_init(struct platform_device *pdev, pll_28nm->pdev = pdev; pll_28nm->id = id; + vco_ref_clk = devm_clk_get(&pdev->dev, "ref"); + if (!IS_ERR(vco_ref_clk)) { + vco_ref_clk_name = __clk_get_name(vco_ref_clk); + } else { + ret = PTR_ERR(vco_ref_clk); + if (ret == -EPROBE_DEFER) + return ERR_PTR(ret); + + dev_warn(&pdev->dev, "'ref' clock is not specified, using default name\n"); + vco_ref_clk_name = "xo"; + } + pll_28nm->mmio = msm_ioremap(pdev, "dsi_pll", "DSI_PLL"); if (IS_ERR_OR_NULL(pll_28nm->mmio)) { dev_err(&pdev->dev, "%s: failed to map pll base\n", __func__); @@ -637,7 +651,7 @@ struct msm_dsi_pll *msm_dsi_pll_28nm_init(struct platform_device *pdev, return ERR_PTR(-EINVAL); } - ret = pll_28nm_register(pll_28nm); + ret = pll_28nm_register(pll_28nm, vco_ref_clk_name); if (ret) { dev_err(&pdev->dev, "failed to register PLL: %d\n", ret); return ERR_PTR(ret); -- 2.20.1.415.g653613c723-goog _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 6/8] arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> ` (2 preceding siblings ...) 2018-12-19 23:55 ` [PATCH v5 3/8] drm/msm/dsi: 28nm " Matthias Kaehlcke @ 2018-12-19 23:55 ` Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 7/8] arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 8/8] ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke 5 siblings, 0 replies; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, Stephen Boyd, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Add 'xo_board' as ref clock for the DSI PHYs, it was previously hardcoded in the PLL 'driver' for the 28nm PHY. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Stephen Boyd <swboyd@chromium.org>' tag Changes in v3: - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag Changes in v2: - patch added to the series --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index d302d8d639a12..89f30f34ff896 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -959,8 +959,9 @@ #clock-cells = <1>; #phy-cells = <0>; - clocks = <&gcc GCC_MDSS_AHB_CLK>; - clock-names = "iface"; + clocks = <&gcc GCC_MDSS_AHB_CLK>, + <&xo_board>; + clock-names = "iface", "ref"; }; }; -- 2.20.1.415.g653613c723-goog _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 7/8] arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> ` (3 preceding siblings ...) 2018-12-19 23:55 ` [PATCH v5 6/8] arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke @ 2018-12-19 23:55 ` Matthias Kaehlcke 2018-12-19 23:55 ` [PATCH v5 8/8] ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke 5 siblings, 0 replies; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, Stephen Boyd, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Add 'bi_tcxo' as ref clock for the DSI PHYs, it was previously hardcoded in the PLL 'driver' for the 10nm PHY. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> --- based on "[v6] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file" (https://patchwork.kernel.org/patch/10712827/) Changes in v5: - rebased on v6 of DPU DT patch Changes in v4: - added 'Reviewed-by: Stephen Boyd <swboyd@chromium.org>' tag Changes in v3: - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag Changes in v2: - patch added to the series --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 3e3ffe096f18a..f278f08906d21 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -1378,8 +1378,9 @@ #clock-cells = <1>; #phy-cells = <0>; - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>; - clock-names = "iface"; + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&rpmhcc RPMH_CXO_CLK>; + clock-names = "iface", "ref"; status = "disabled"; }; @@ -1444,8 +1445,9 @@ #clock-cells = <1>; #phy-cells = <0>; - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>; - clock-names = "iface"; + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&rpmhcc RPMH_CXO_CLK>; + clock-names = "iface", "ref"; status = "disabled"; }; -- 2.20.1.415.g653613c723-goog _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 8/8] ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> ` (4 preceding siblings ...) 2018-12-19 23:55 ` [PATCH v5 7/8] arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs Matthias Kaehlcke @ 2018-12-19 23:55 ` Matthias Kaehlcke 5 siblings, 0 replies; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, Stephen Boyd, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Add 'xo_board' as ref clock for the DSI PHY, it was previously hardcoded in the PLL 'driver' for the 28nm 8960 PHY. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Stephen Boyd <swboyd@chromium.org>' tag Changes in v3: - patch added to the series --- arch/arm/boot/dts/qcom-apq8064.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi index 48c3cf4276101..d337ae9326cd8 100644 --- a/arch/arm/boot/dts/qcom-apq8064.dtsi +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi @@ -1338,8 +1338,9 @@ <0x04700300 0x200>, <0x04700500 0x5c>; reg-names = "dsi_pll", "dsi_phy", "dsi_phy_regulator"; - clock-names = "iface_clk"; - clocks = <&mmcc DSI_M_AHB_CLK>; + clock-names = "iface_clk", "ref"; + clocks = <&mmcc DSI_M_AHB_CLK>, + <&xo_board>; }; -- 2.20.1.415.g653613c723-goog _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 4/8] drm/msm/dsi: 14nm PHY: Get ref clock from the DT 2018-12-19 23:55 [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT Matthias Kaehlcke [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> @ 2018-12-19 23:55 ` Matthias Kaehlcke [not found] ` <20181219235528.114830-5-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-12-19 23:55 ` [PATCH v5 5/8] drm/msm/dsi: 10nm " Matthias Kaehlcke 2019-01-29 0:05 ` [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks " Matthias Kaehlcke 3 siblings, 1 reply; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, Archit Taneja, Sean Paul, Rajesh Yadav, Douglas Anderson, Stephen Boyd, Jeykumar Sankaran, Matthias Kaehlcke Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Note: This change could break old out-of-tree DTS files that use the 14nm PHY. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> --- Changes in v5: - pass the ref clock name to _register() instead of storing a point to the clk object in the PLL data structure Changes in v4: - none Changes in v3: - fixed check for EPROBE_DEFER - added note to commit message about breaking old DTS files - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag Changes in v2: - patch added to the series --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c | 23 +++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c index 71fe60e5f01f1..9a647d93a7e0b 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c @@ -40,7 +40,6 @@ #define NUM_PROVIDED_CLKS 2 -#define VCO_REF_CLK_RATE 19200000 #define VCO_MIN_RATE 1300000000UL #define VCO_MAX_RATE 2600000000UL @@ -591,7 +590,7 @@ static int dsi_pll_14nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, parent_rate); pll_14nm->vco_current_rate = rate; - pll_14nm->vco_ref_clk_rate = VCO_REF_CLK_RATE; + pll_14nm->vco_ref_clk_rate = parent_rate; dsi_pll_14nm_input_init(pll_14nm); @@ -947,11 +946,12 @@ static struct clk_hw *pll_14nm_postdiv_register(struct dsi_pll_14nm *pll_14nm, return &pll_postdiv->hw; } -static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm) +static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, + const char *ref_clk_name) { char clk_name[32], parent[32], vco_name[32]; struct clk_init_data vco_init = { - .parent_names = (const char *[]){ "xo" }, + .parent_names = &ref_clk_name, .num_parents = 1, .name = vco_name, .flags = CLK_IGNORE_UNUSED, @@ -1050,6 +1050,8 @@ struct msm_dsi_pll *msm_dsi_pll_14nm_init(struct platform_device *pdev, int id) { struct dsi_pll_14nm *pll_14nm; struct msm_dsi_pll *pll; + struct clk *vco_ref_clk; + const char *vco_ref_clk_name; int ret; if (!pdev) @@ -1065,6 +1067,17 @@ struct msm_dsi_pll *msm_dsi_pll_14nm_init(struct platform_device *pdev, int id) pll_14nm->id = id; pll_14nm_list[id] = pll_14nm; + vco_ref_clk = devm_clk_get(&pdev->dev, "ref"); + if (IS_ERR(vco_ref_clk)) { + ret = PTR_ERR(vco_ref_clk); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, "couldn't get 'ref' clock: %d\n", + ret); + return ERR_PTR(ret); + } + + vco_ref_clk_name = __clk_get_name(vco_ref_clk); + pll_14nm->phy_cmn_mmio = msm_ioremap(pdev, "dsi_phy", "DSI_PHY"); if (IS_ERR_OR_NULL(pll_14nm->phy_cmn_mmio)) { dev_err(&pdev->dev, "failed to map CMN PHY base\n"); @@ -1094,7 +1107,7 @@ struct msm_dsi_pll *msm_dsi_pll_14nm_init(struct platform_device *pdev, int id) pll->en_seq_cnt = 1; pll->enable_seqs[0] = dsi_pll_14nm_enable_seq; - ret = pll_14nm_register(pll_14nm); + ret = pll_14nm_register(pll_14nm, vco_ref_clk_name); if (ret) { dev_err(&pdev->dev, "failed to register PLL: %d\n", ret); return ERR_PTR(ret); -- 2.20.1.415.g653613c723-goog ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <20181219235528.114830-5-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH v5 4/8] drm/msm/dsi: 14nm PHY: Get ref clock from the DT [not found] ` <20181219235528.114830-5-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> @ 2018-12-21 0:53 ` Stephen Boyd 0 siblings, 0 replies; 13+ messages in thread From: Stephen Boyd @ 2018-12-21 0:53 UTC (permalink / raw) To: Andy Gross, David Airlie, David Brown, Mark Rutland, Rob Clark, Rob Herring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Quoting Matthias Kaehlcke (2018-12-19 15:55:24) > Get the ref clock of the PHY from the device tree instead of > hardcoding its name and rate. > > Note: This change could break old out-of-tree DTS files that > use the 14nm PHY. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org> _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v5 5/8] drm/msm/dsi: 10nm PHY: Get ref clock from the DT 2018-12-19 23:55 [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT Matthias Kaehlcke [not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-12-19 23:55 ` [PATCH v5 4/8] drm/msm/dsi: 14nm PHY: Get ref clock from the DT Matthias Kaehlcke @ 2018-12-19 23:55 ` Matthias Kaehlcke [not found] ` <20181219235528.114830-6-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2019-01-29 0:05 ` [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks " Matthias Kaehlcke 3 siblings, 1 reply; 13+ messages in thread From: Matthias Kaehlcke @ 2018-12-19 23:55 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, Archit Taneja, Sean Paul, Rajesh Yadav, Douglas Anderson, Stephen Boyd, Jeykumar Sankaran, Matthias Kaehlcke Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Note: This change could break old out-of-tree DTS files that use the 10nm PHY Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> --- Changes in v5: - pass the ref clock name to _register() instead of storing a point to the clk object in the PLL data structure Changes in v4: - none Changes in v3: - fixed check for EPROBE_DEFER - added note to commit message about breaking old DTS files - added 'Reviewed-by: Douglas Anderson <dianders@chromium.org>' tag Changes in v2: - remove anonymous array in clk_init_data assignment - log error code if devm_clk_get() fails - don't log devm_clk_get() failures for -EPROBE_DEFER - updated commit message --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index 4c03f0b7343ed..adbe5395f4f38 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c @@ -625,12 +625,14 @@ static void dsi_pll_10nm_destroy(struct msm_dsi_pll *pll) * state to follow the master PLL's divider/mux state. Therefore, we don't * require special clock ops that also configure the slave PLL registers */ -static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm) +static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, + const char *ref_clk_name) { char clk_name[32], parent[32], vco_name[32]; char parent2[32], parent3[32], parent4[32]; + struct clk_init_data vco_init = { - .parent_names = (const char *[]){ "xo" }, + .parent_names = &ref_clk_name, .num_parents = 1, .name = vco_name, .flags = CLK_IGNORE_UNUSED, @@ -771,6 +773,8 @@ struct msm_dsi_pll *msm_dsi_pll_10nm_init(struct platform_device *pdev, int id) { struct dsi_pll_10nm *pll_10nm; struct msm_dsi_pll *pll; + struct clk *vco_ref_clk; + const char *vco_ref_clk_name; int ret; if (!pdev) @@ -786,6 +790,16 @@ struct msm_dsi_pll *msm_dsi_pll_10nm_init(struct platform_device *pdev, int id) pll_10nm->id = id; pll_10nm_list[id] = pll_10nm; + vco_ref_clk = devm_clk_get(&pdev->dev, "ref"); + if (IS_ERR(vco_ref_clk)) { + ret = PTR_ERR(vco_ref_clk); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, "couldn't get 'ref' clock: %d\n", + ret); + return ERR_PTR(ret); + } + vco_ref_clk_name = __clk_get_name(vco_ref_clk); + pll_10nm->phy_cmn_mmio = msm_ioremap(pdev, "dsi_phy", "DSI_PHY"); if (IS_ERR_OR_NULL(pll_10nm->phy_cmn_mmio)) { dev_err(&pdev->dev, "failed to map CMN PHY base\n"); @@ -811,7 +825,7 @@ struct msm_dsi_pll *msm_dsi_pll_10nm_init(struct platform_device *pdev, int id) pll_10nm->vco_delay = 1; - ret = pll_10nm_register(pll_10nm); + ret = pll_10nm_register(pll_10nm, vco_ref_clk_name); if (ret) { dev_err(&pdev->dev, "failed to register PLL: %d\n", ret); return ERR_PTR(ret); -- 2.20.1.415.g653613c723-goog ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <20181219235528.114830-6-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH v5 5/8] drm/msm/dsi: 10nm PHY: Get ref clock from the DT [not found] ` <20181219235528.114830-6-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> @ 2018-12-21 0:53 ` Stephen Boyd 0 siblings, 0 replies; 13+ messages in thread From: Stephen Boyd @ 2018-12-21 0:53 UTC (permalink / raw) To: Andy Gross, David Airlie, David Brown, Mark Rutland, Rob Clark, Rob Herring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Archit Taneja, Rajesh Yadav, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Douglas Anderson, Matthias Kaehlcke, Sean Paul, Jeykumar Sankaran, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Quoting Matthias Kaehlcke (2018-12-19 15:55:25) > Get the ref clock of the PHY from the device tree instead of > hardcoding its name and rate. > > Note: This change could break old out-of-tree DTS files that > use the 10nm PHY > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org> _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT 2018-12-19 23:55 [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT Matthias Kaehlcke ` (2 preceding siblings ...) 2018-12-19 23:55 ` [PATCH v5 5/8] drm/msm/dsi: 10nm " Matthias Kaehlcke @ 2019-01-29 0:05 ` Matthias Kaehlcke 2019-01-31 19:24 ` Sean Paul 3 siblings, 1 reply; 13+ messages in thread From: Matthias Kaehlcke @ 2019-01-29 0:05 UTC (permalink / raw) To: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, Archit Taneja, Sean Paul, Rajesh Yadav, Douglas Anderson, Stephen Boyd, Jeykumar Sankaran Hi, this series has gone through multiple rounds of review and there are no outstanding comments. It seems it should be ready to land, or is there anything left that needs to be addressed? Thanks Matthias On Wed, Dec 19, 2018 at 03:55:20PM -0800, Matthias Kaehlcke wrote: > The MSM DSI PHY drivers currently hardcode the name and the rate of > the PHY ref clock. Get the ref clock from the device tree instead. > > Note: testing of this series was limited to SDM845 and the 10nm PHY > > Major changes in v5: > - none (see per-patch change log for minor changes) > > Major changes in v4: > - always use parent rate for 28nm and 28nm 8960 PHYs > > Major changes in v3: > - keep supporting DTs without ref clock for the 28nm and the 28nm > 8960 PHYs > - added patch to add ref clock to qcom-apq8064.dtsi > > Major changes in v2: > - apply to all MSM DSI PHY drivers, not only 10nm > > Matthias Kaehlcke (8): > dt-bindings: msm/dsi: Add ref clock for PHYs > drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT > drm/msm/dsi: 28nm PHY: Get ref clock from the DT > drm/msm/dsi: 14nm PHY: Get ref clock from the DT > drm/msm/dsi: 10nm PHY: Get ref clock from the DT > arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY > arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs > ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY > > .../devicetree/bindings/display/msm/dsi.txt | 1 + > arch/arm/boot/dts/qcom-apq8064.dtsi | 5 +-- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 +-- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++--- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 20 +++++++++-- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c | 23 +++++++++--- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c | 36 +++++++++++++------ > .../gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c | 24 ++++++++++--- > 8 files changed, 92 insertions(+), 32 deletions(-) > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT 2019-01-29 0:05 ` [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks " Matthias Kaehlcke @ 2019-01-31 19:24 ` Sean Paul 0 siblings, 0 replies; 13+ messages in thread From: Sean Paul @ 2019-01-31 19:24 UTC (permalink / raw) To: Matthias Kaehlcke Cc: Rob Clark, David Airlie, Rob Herring, Mark Rutland, Andy Gross, David Brown, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, Archit Taneja, Sean Paul, Rajesh Yadav, Douglas Anderson, Stephen Boyd, Jeykumar Sankaran On Mon, Jan 28, 2019 at 04:05:34PM -0800, Matthias Kaehlcke wrote: > Hi, > > this series has gone through multiple rounds of review and there are > no outstanding comments. It seems it should be ready to land, or is > there anything left that needs to be addressed? >From the drm side, I think we'll need Andy to pick up the dt-bindings and dts changes, and then the msm/dsi changes can be picked once that's merged. We could also do a topic branch if that suits everyone. Sean > > Thanks > > Matthias > > On Wed, Dec 19, 2018 at 03:55:20PM -0800, Matthias Kaehlcke wrote: > > The MSM DSI PHY drivers currently hardcode the name and the rate of > > the PHY ref clock. Get the ref clock from the device tree instead. > > > > Note: testing of this series was limited to SDM845 and the 10nm PHY > > > > Major changes in v5: > > - none (see per-patch change log for minor changes) > > > > Major changes in v4: > > - always use parent rate for 28nm and 28nm 8960 PHYs > > > > Major changes in v3: > > - keep supporting DTs without ref clock for the 28nm and the 28nm > > 8960 PHYs > > - added patch to add ref clock to qcom-apq8064.dtsi > > > > Major changes in v2: > > - apply to all MSM DSI PHY drivers, not only 10nm > > > > Matthias Kaehlcke (8): > > dt-bindings: msm/dsi: Add ref clock for PHYs > > drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT > > drm/msm/dsi: 28nm PHY: Get ref clock from the DT > > drm/msm/dsi: 14nm PHY: Get ref clock from the DT > > drm/msm/dsi: 10nm PHY: Get ref clock from the DT > > arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY > > arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs > > ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY > > > > .../devicetree/bindings/display/msm/dsi.txt | 1 + > > arch/arm/boot/dts/qcom-apq8064.dtsi | 5 +-- > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 +-- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++--- > > drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 20 +++++++++-- > > drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c | 23 +++++++++--- > > drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c | 36 +++++++++++++------ > > .../gpu/drm/msm/dsi/pll/dsi_pll_28nm_8960.c | 24 ++++++++++--- > > 8 files changed, 92 insertions(+), 32 deletions(-) > > -- Sean Paul, Software Engineer, Google / Chromium OS ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-01-31 19:24 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 23:55 [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT Matthias Kaehlcke
[not found] ` <20181219235528.114830-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-12-19 23:55 ` [PATCH v5 1/8] dt-bindings: msm/dsi: Add ref clock for PHYs Matthias Kaehlcke
2018-12-19 23:55 ` [PATCH v5 2/8] drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT Matthias Kaehlcke
2018-12-19 23:55 ` [PATCH v5 3/8] drm/msm/dsi: 28nm " Matthias Kaehlcke
2018-12-19 23:55 ` [PATCH v5 6/8] arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke
2018-12-19 23:55 ` [PATCH v5 7/8] arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs Matthias Kaehlcke
2018-12-19 23:55 ` [PATCH v5 8/8] ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke
2018-12-19 23:55 ` [PATCH v5 4/8] drm/msm/dsi: 14nm PHY: Get ref clock from the DT Matthias Kaehlcke
[not found] ` <20181219235528.114830-5-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-12-21 0:53 ` Stephen Boyd
2018-12-19 23:55 ` [PATCH v5 5/8] drm/msm/dsi: 10nm " Matthias Kaehlcke
[not found] ` <20181219235528.114830-6-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-12-21 0:53 ` Stephen Boyd
2019-01-29 0:05 ` [PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks " Matthias Kaehlcke
2019-01-31 19:24 ` Sean Paul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).