* [PATCH v4 2/2] dt-bindings: iio: light: Add max44009
[not found] <01f62d9d67110fd2c2f34e7835973fc6874a9fe8.1548947951.git.bobbyeshleman@gmail.com>
@ 2019-01-31 15:49 ` Robert Eshleman
2019-02-02 15:54 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Robert Eshleman @ 2019-01-31 15:49 UTC (permalink / raw)
To: bobbyeshleman
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Mark Rutland, linux-iio,
devicetree, linux-kernel
Adds device tree bindings for the max44009 light sensor.
Signed-off-by: Robert Eshleman <bobbyeshleman@gmail.com>
---
Changes to v4:
- Add subsystem to subject line
- Change node name to be 'light-sensor'
- Clean up style
Changes to v3:
- None
Changes to v2:
- Clean up style
.../bindings/iio/light/max44009.txt | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/max44009.txt
diff --git a/Documentation/devicetree/bindings/iio/light/max44009.txt b/Documentation/devicetree/bindings/iio/light/max44009.txt
new file mode 100644
index 000000000000..557297c86fba
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/max44009.txt
@@ -0,0 +1,25 @@
+* MAX44009 Ambient Light Sensor
+
+Required properties:
+
+- compatible: should be "maxim,max44009"
+- reg: the I2C address of the device (default is <0x4a>)
+
+Optional properties:
+
+- interrupts: interrupt mapping for GPIO IRQ. Should be configured with
+ IRQ_TYPE_EDGE_FALLING.
+
+Refer to interrupt-controller/interrupts.txt for generic interrupt client
+node bindings.
+
+Example:
+
+max44009: light-sensor@4a {
+ compatible = "maxim,max44009";
+ reg = <0x4a>;
+
+ interrupt-parent = <&gpio1>;
+ interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
+};
+
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: iio: light: Add max44009
2019-01-31 15:49 ` [PATCH v4 2/2] dt-bindings: iio: light: Add max44009 Robert Eshleman
@ 2019-02-02 15:54 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-02-02 15:54 UTC (permalink / raw)
To: Robert Eshleman
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, Mark Rutland, linux-iio, devicetree, linux-kernel
On Thu, 31 Jan 2019 07:49:16 -0800
Robert Eshleman <bobbyeshleman@gmail.com> wrote:
> Adds device tree bindings for the max44009 light sensor.
>
> Signed-off-by: Robert Eshleman <bobbyeshleman@gmail.com>
Still time for Rob to comment if he want's to, but I think
with few tweaks as below this matches what he asked for.
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> Changes to v4:
> - Add subsystem to subject line
> - Change node name to be 'light-sensor'
> - Clean up style
>
> Changes to v3:
> - None
>
> Changes to v2:
> - Clean up style
>
> .../bindings/iio/light/max44009.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/max44009.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/max44009.txt b/Documentation/devicetree/bindings/iio/light/max44009.txt
> new file mode 100644
> index 000000000000..557297c86fba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/max44009.txt
> @@ -0,0 +1,25 @@
> +* MAX44009 Ambient Light Sensor
> +
> +Required properties:
> +
> +- compatible: should be "maxim,max44009"
> +- reg: the I2C address of the device (default is <0x4a>)
> +
> +Optional properties:
> +
> +- interrupts: interrupt mapping for GPIO IRQ. Should be configured with
> + IRQ_TYPE_EDGE_FALLING.
> +
> +Refer to interrupt-controller/interrupts.txt for generic interrupt client
> +node bindings.
> +
> +Example:
> +
> +max44009: light-sensor@4a {
The label is only useful if something is going to cross reference it.
Can't see that happening so dropped it. Above now reads.
light-sensor@4a {
> + compatible = "maxim,max44009";
> + reg = <0x4a>;
> +
> + interrupt-parent = <&gpio1>;
> + interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
> +};
> +
Cleaned up extra entirely blank line at end of file.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-02 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <01f62d9d67110fd2c2f34e7835973fc6874a9fe8.1548947951.git.bobbyeshleman@gmail.com>
2019-01-31 15:49 ` [PATCH v4 2/2] dt-bindings: iio: light: Add max44009 Robert Eshleman
2019-02-02 15:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).