From: David Miller <davem@davemloft.net>
To: yangbo.lu@nxp.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
richardcochran@gmail.com, robh+dt@kernel.org,
claudiu.manoil@nxp.com
Subject: Re: [v2, 0/9] Add ENETC PTP clock driver
Date: Sun, 03 Feb 2019 12:11:44 -0800 (PST) [thread overview]
Message-ID: <20190203.121144.623666032377925349.davem@davemloft.net> (raw)
In-Reply-To: <20190203.113921.1847323007238920901.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 03 Feb 2019 11:39:21 -0800 (PST)
> From: Yangbo Lu <yangbo.lu@nxp.com>
> Date: Sat, 2 Feb 2019 10:56:58 +0800
>
>> There is same QorIQ 1588 timer IP block on the new ENETC Ethernet
>> controller with eTSEC/DPAA Ethernet controllers. However it's
>> different endianness (little-endian) and using PCI driver.
>>
>> To support ENETC PTP driver, ptp_qoriq driver needed to be
>> reworked to make functions global for reusing, to add little-
>> endian support, to add ENETC memory map support, and to add
>> ENETC dependency for ptp_qoriq driver.
>>
>> In addition, although ENETC PTP driver is a PCI driver, the dts
>> node still could be used. Currently the ls1028a dtsi which is
>> the only platform by now using ENETC is not complete, so there
>> is still dependency for ENETC PTP node upstreaming. This will
>> be done in the near future. The hardware timestamping support
>> for ENETC is done but needs to be reworked with new method in
>> internal git tree, and will be sent out soon.
>
> Series applied.
Once AGAIN, I had to revert:
[davem@localhost net-next]$ make -s -j8
ERROR: "ptp_qoriq_remove_debugfs" [drivers/net/ethernet/freescale/enetc/fsl-enetc-ptp.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
make: *** [Makefile:1262: modules] Error 2
Please do an allmodconfig build and don't resubmit this until it all
passes.
Thank you.
next prev parent reply other threads:[~2019-02-03 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 2:56 [v2, 0/9] Add ENETC PTP clock driver Yangbo Lu
2019-02-02 2:56 ` [v2, 1/9] ptp_qoriq: make structure/function names more consistent Yangbo Lu
2019-02-02 2:57 ` [v2, 2/9] ptp_qoriq: make ptp operations global Yangbo Lu
2019-02-02 2:57 ` [v2, 3/9] ptp_qoriq: convert to use ptp_qoriq_init() Yangbo Lu
2019-02-02 2:57 ` [v2, 4/9] ptp_qoriq: add little enadian support Yangbo Lu
2019-02-02 2:57 ` [v2, 5/9] dt-binding: ptp_qoriq: add little-endian support Yangbo Lu
2019-02-02 2:57 ` [v2, 6/9] ptp_qoriq: fix register memory map Yangbo Lu
2019-02-02 2:57 ` [v2, 7/9] ptp: add QorIQ PTP support for ENETC Yangbo Lu
2019-02-02 2:57 ` [v2, 8/9] enetc: add PTP clock driver Yangbo Lu
2019-02-02 2:57 ` [v2, 9/9] MAINTAINERS: add enetc_ptp driver into QorIQ PTP list Yangbo Lu
2019-02-03 19:39 ` [v2, 0/9] Add ENETC PTP clock driver David Miller
2019-02-03 20:11 ` David Miller [this message]
2019-02-12 4:02 ` Y.b. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190203.121144.623666032377925349.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).