From: Boris Brezillon <bbrezillon@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Mathieu Malaterre <malat@debian.org>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 9/9] mtd: rawnand: jz4780-bch: Add support for the JZ4740
Date: Sun, 3 Feb 2019 15:16:04 +0100 [thread overview]
Message-ID: <20190203151604.23061e2a@bbrezillon> (raw)
In-Reply-To: <1549202293.1950.2@crapouillou.net>
On Sun, 03 Feb 2019 10:58:13 -0300
Paul Cercueil <paul@crapouillou.net> wrote:
> Le dim. 3 févr. 2019 à 4:35, Boris Brezillon <bbrezillon@kernel.org>
> a écrit :
> > On Sat, 2 Feb 2019 20:19:26 -0300
> > Paul Cercueil <paul@crapouillou.net> wrote:
> >
> >> Add the backend code for the jz4780-bch driver to support the JZ4740
> >> SoC from Ingenic.
> >>
> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >> ---
> >>
> >> Changes:
> >>
> >> v2: New patch
> >>
> >> drivers/mtd/nand/raw/ingenic/Makefile | 2 +-
> >> drivers/mtd/nand/raw/ingenic/jz4740_bch.c | 173
> >> ++++++++++++++++++
> >> .../mtd/nand/raw/ingenic/jz4780_bch_common.c | 1 +
> >> .../nand/raw/ingenic/jz4780_bch_internal.h | 1 +
> >> 4 files changed, 176 insertions(+), 1 deletion(-)
> >> create mode 100644 drivers/mtd/nand/raw/ingenic/jz4740_bch.c
> >>
> >> diff --git a/drivers/mtd/nand/raw/ingenic/Makefile
> >> b/drivers/mtd/nand/raw/ingenic/Makefile
> >> index f38b467490cf..d16c96113a93 100644
> >> --- a/drivers/mtd/nand/raw/ingenic/Makefile
> >> +++ b/drivers/mtd/nand/raw/ingenic/Makefile
> >> @@ -1,3 +1,3 @@
> >> obj-$(CONFIG_MTD_NAND_JZ4740) += jz4740_nand.o
> >> obj-$(CONFIG_MTD_NAND_JZ4780) += jz4780_nand.o jz4780_bch_common.o
> >> \
> >> - jz4780_bch.o jz4725b_bch.o
> >> + jz4780_bch.o jz4725b_bch.o jz4740_bch.o
> >
> > I still don't see the point of the jz4780_bch_common/jz47xxx_bch
> > separation. You seem to always embed all objects anyway, so you can
> > just put the code for both engines in the same source file and decide
> > which one to use based on the compat (which you already do anyway).
>
> Each SoC has a different set of registers for the BCH hardware. I can
> try to
> cram everything into one file, but it won't be that much cleaner.
Then maybe they deserve separate drivers/modules.
BTW, didn't you say that one IP uses Reed-Salomon instead of BCH. I'd
suggest prefixing structs and functions with jz47xx_ecc instead of
jz47xx_bch and naming the common part jz47xx_ecc.c to reflect that.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-03 14:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 23:19 [PATCH v2 0/9] Ingenic JZ4780 NAND patchset v2 Paul Cercueil
2019-02-02 23:19 ` [PATCH v2 1/9] mtd: rawnand: Move drivers for Ingenic SoCs to subfolder Paul Cercueil
2019-02-02 23:19 ` [PATCH v2 2/9] dt-bindings: mtd: ingenic: Add compatible strings for the JZ4740 Paul Cercueil
2019-02-18 19:20 ` Rob Herring
2019-02-02 23:19 ` [PATCH v2 3/9] mtd: rawnand: jz4780: Use SPDX license notifiers Paul Cercueil
2019-02-02 23:19 ` [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740 Paul Cercueil
2019-02-03 7:31 ` Boris Brezillon
2019-02-03 13:56 ` Paul Cercueil
2019-02-03 14:08 ` Boris Brezillon
2019-02-03 14:10 ` Paul Cercueil
2019-02-03 14:24 ` Boris Brezillon
2019-02-02 23:19 ` [PATCH v2 5/9] mtd: rawnand: jz4780: Add ooblayout for the JZ4725B Paul Cercueil
2019-02-03 7:21 ` Boris Brezillon
2019-02-02 23:19 ` [PATCH v2 6/9] mtd: rawnand: jz4780: Add ooblayout for the Qi Ben Nanonote Paul Cercueil
2019-02-03 7:30 ` Boris Brezillon
2019-02-02 23:19 ` [PATCH v2 7/9] mtd: rawnand: jz4780-bch: Separate top-level and SoC specific code Paul Cercueil
2019-02-02 23:19 ` [PATCH v2 8/9] mtd: rawnand: jz4780-bch: Add support for the JZ4725B Paul Cercueil
2019-02-02 23:19 ` [PATCH v2 9/9] mtd: rawnand: jz4780-bch: Add support for the JZ4740 Paul Cercueil
2019-02-03 7:35 ` Boris Brezillon
2019-02-03 13:58 ` Paul Cercueil
2019-02-03 14:16 ` Boris Brezillon [this message]
2019-02-03 14:56 ` Paul Cercueil
2019-02-03 15:07 ` Boris Brezillon
2019-02-03 15:41 ` Paul Cercueil
2019-02-04 9:26 ` kbuild test robot
2019-02-04 10:02 ` kbuild test robot
2019-02-03 7:20 ` [PATCH v2 0/9] Ingenic JZ4780 NAND patchset v2 Boris Brezillon
2019-02-03 13:01 ` Paul Cercueil
2019-02-03 14:04 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190203151604.23061e2a@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=malat@debian.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).