From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v8 1/8] mfd: regulator: clk: split rohm-bd718x7.h Date: Thu, 7 Feb 2019 11:41:03 +0000 Message-ID: <20190207114103.GF20638@dell> References: <58a56ac25564baa221d471e878a3e4f5d9081f36.1549523718.git.matti.vaittinen@fi.rohmeurope.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <58a56ac25564baa221d471e878a3e4f5d9081f36.1549523718.git.matti.vaittinen@fi.rohmeurope.com> Sender: linux-kernel-owner@vger.kernel.org To: Matti Vaittinen Cc: Matti Vaittinen , Guenter Roeck , heikki.haikola@fi.rohmeurope.com, mikko.mutanen@fi.rohmeurope.com, robh+dt@kernel.org, mark.rutland@arm.com, broonie@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, sre@kernel.org, lgirdwood@gmail.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, wim@linux-watchdog.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, 07 Feb 2019, Matti Vaittinen wrote: > Split the bd718x7.h to ROHM common and bd718x7 specific parts > so that we do not need to add same things in every new ROHM > PMIC header. Please note that this change requires changes also > in bd718x7 sub-device drivers for regulators and clk. > > Signed-off-by: Matti Vaittinen > Acked-by: Mark Brown > Acked-by: Stephen Boyd > --- > > Please note that I maintained the acks from Mark and Stephen even > though this is a squash of 3 commits and both Mark and Stephen had > only acked one of the patches. (The patch which touched their area > clk for Stephen, regulators for Mark). I interpreted their acks as > 'the split is in general Ok and portion I am interested in is fine' > and thus maintained the acks. Please let me know if this is not Ok. > > drivers/clk/clk-bd718x7.c | 6 +++--- > drivers/mfd/rohm-bd718x7.c | 23 ++++++++++++----------- > drivers/regulator/bd718x7-regulator.c | 24 ++++++++++++------------ > include/linux/mfd/rohm-bd718x7.h | 22 ++++++++-------------- > include/linux/mfd/rohm-generic.h | 20 ++++++++++++++++++++ > 5 files changed, 55 insertions(+), 40 deletions(-) > create mode 100644 include/linux/mfd/rohm-generic.h For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog