From: Johan Hovold <johan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: msm8916-wcd-analog: add missing license information
Date: Fri, 8 Feb 2019 16:15:02 +0100 [thread overview]
Message-ID: <20190208151502.GP4686@localhost> (raw)
In-Reply-To: <20190208115341.GB6695@sirena.org.uk>
On Fri, Feb 08, 2019 at 11:53:41AM +0000, Mark Brown wrote:
> On Thu, Feb 07, 2019 at 05:57:53PM +0100, Johan Hovold wrote:
>
> > +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> > @@ -1,3 +1,8 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> > + */
>
> Please use a C++ comment for the whole thing so it looks more consistent
> with the rest of ASoC (and a bit neater in general).
Ah, yes, that makes sense for consistency since you've already enforced
that style. And while I don't think the all-c++-comment headers look
better in general, for the single copyright statement case it's not too
bad.
v2 under way.
Johan
next prev parent reply other threads:[~2019-02-08 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 16:57 [PATCH 0/3] ASoC: msm8916-wcd: license and documentation fixes Johan Hovold
2019-02-07 16:57 ` [PATCH 1/3] ASoC: msm8916-wcd-analog: add missing license information Johan Hovold
2019-02-08 11:53 ` Mark Brown
2019-02-08 15:15 ` Johan Hovold [this message]
2019-02-08 16:42 ` Mark Brown
2019-02-07 16:57 ` [PATCH 2/3] ASoC: msm8916-wcd-digital: convert license header to SPDX Johan Hovold
2019-02-07 16:57 ` [PATCH 3/3] dt-bindings: sound: msm8916-wcd-analog: fix example regulator names Johan Hovold
2019-02-08 13:11 ` Applied "dt-bindings: sound: msm8916-wcd-analog: fix example regulator names" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208151502.GP4686@localhost \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).