From: Lee Jones <lee.jones@linaro.org>
To: Mark Zhang <markz@nvidia.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Venkat Reddy Talla <vreddytalla@nvidia.com>
Subject: Re: [PATCH v3 1/4] mfd: max77620: Add backup battery charger support
Date: Tue, 12 Feb 2019 08:06:11 +0000 [thread overview]
Message-ID: <20190212080611.GM20638@dell> (raw)
In-Reply-To: <20190212064353.7451-2-markz@nvidia.com>
On Tue, 12 Feb 2019, Mark Zhang wrote:
> Add PMIC configurations for backup battery charger, which
> is a constant voltage and constant current style charger
> with a series output resistance.
>
> The max77620 register CNFGBBC(addr: 0x04) defines the
> parameters of backup battery charger. This patch adds
> support for it.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Venkat Reddy Talla <vreddytalla@nvidia.com>
> Signed-off-by: Mark Zhang <markz@nvidia.com>
> ---
> drivers/mfd/max77620.c | 80 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 80 insertions(+)
My previous review comments still apply.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-12 8:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 6:43 [PATCH v3 0/4] Add max77620 charging & low battery support Mark Zhang
2019-02-12 6:43 ` [PATCH v3 1/4] mfd: max77620: Add backup battery charger support Mark Zhang
2019-02-12 8:06 ` Lee Jones [this message]
2019-02-12 6:43 ` [PATCH v3 2/4] mfd: max77620: add documentation for backup battery charging Mark Zhang
2019-02-18 18:06 ` Rob Herring
2019-02-19 2:07 ` Mark Zhang
2019-02-19 2:09 ` Mark Zhang
2019-02-19 15:18 ` Rob Herring
2019-02-12 6:43 ` [PATCH v3 3/4] mfd: max77620: Add low battery monitor support Mark Zhang
2019-02-12 6:43 ` [PATCH v3 4/4] mfd: max77620: add documentation for low battery monitoring Mark Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212080611.GM20638@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=markz@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=vreddytalla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).