From: Mark Brown <broonie@kernel.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, Robin Gong <yibin.gong@nxp.com>,
Elven Wang <elven.wang@nxp.com>,
Anson Huang <anson.huang@nxp.com>
Subject: Re: [RFC PATCH v1 3/3] regulator: bd718x7: Support SNVS low power state
Date: Tue, 12 Feb 2019 16:08:31 +0000 [thread overview]
Message-ID: <20190212160831.GF20635@sirena.org.uk> (raw)
In-Reply-To: <06c2f2f730b07caeb1f2fb86be60c02b21d7bea9.1549980347.git.matti.vaittinen@fi.rohmeurope.com>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Tue, Feb 12, 2019 at 04:19:38PM +0200, Matti Vaittinen wrote:
> read ROHM BD71837 / BD71847 specific device tree bindings for
> controlling the PMIC shutdown/reset states and voltages for
> different HW states. The PMIC was designed to be used with NXP
> i.MX8 SoC and it supports SNVS low power state which seems to
> be typical for NXP i.MX SoCs. However, when SNVS is used we must
> not allow SW to control enabling/disabling those regulators which
> are crucial for system to boot as there is a HW limitation which
> causes SW controlled regulators to be kept shut down after SNVS
> reset.
>
> Allow setting the SNVS to be used as reset target state and allow
> marking those regulators which are critical for boot.
The general idea seems fine but I'm wondering if we should use the
existing bindings and just prevent any change with fixed configurations
- that *should* just be a case of picking appropriate constraints I
think. Why does this need completely new properties other than
preventing the user from shooting themselves in the foot?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-12 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 14:16 [RFC PATCH v1 0/3] bd718x7: Support SNVS low power state Matti Vaittinen
2019-02-12 14:17 ` [RFC PATCH v1 1/3] devicetree: bindings: bd718x7: document HW state related ROHM specific properties Matti Vaittinen
2019-02-12 14:18 ` [RFC PATCH v1 2/3] regulator: add regulator_desc_list_voltage_linear_range Matti Vaittinen
2019-02-12 15:34 ` Mark Brown
2019-02-12 14:19 ` [RFC PATCH v1 3/3] regulator: bd718x7: Support SNVS low power state Matti Vaittinen
2019-02-12 16:08 ` Mark Brown [this message]
2019-02-13 7:38 ` Matti Vaittinen
2019-02-13 8:33 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212160831.GF20635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=elven.wang@nxp.com \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).