From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay11.mail.gandi.net ([217.70.178.231]:49931 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729358AbfBLXKt (ORCPT ); Tue, 12 Feb 2019 18:10:49 -0500 Date: Wed, 13 Feb 2019 00:10:46 +0100 From: Alexandre Belloni Subject: Re: [PATCH v3 4/4] dt-bindings: rtc: Update for new chip in isl1208 series Message-ID: <20190212231046.GF10129@piout.net> References: <20190212023225.2710-1-tpiepho@impinj.com> <20190212023225.2710-4-tpiepho@impinj.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212023225.2710-4-tpiepho@impinj.com> Sender: devicetree-owner@vger.kernel.org To: Trent Piepho Cc: "linux-rtc@vger.kernel.org" , Alessandro Zummo , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" List-ID: On 12/02/2019 02:34:05+0000, Trent Piepho wrote: > Since this documents multiple chips controlled by the isl1208 driver, > name it isil,isl1208.txt, as the convention is to use the base driver > name in the bindings document for drivers with multiple devices. > > Include all chips supported by this driver in the docs. Make it > clear which properties apply to which chips. > > Expand documentation for existing isil,evienb property to explain > operation in more detail. Existing docs just describe it in terms of > setting a bit in a register. > > CC: Alessandro Zummo > CC: Alexandre Belloni > CC: Rob Herring > CC: Mark Rutland > CC: devicetree@vger.kernel.org > Signed-off-by: Trent Piepho > --- > .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/isil,isl1219.txt | 29 ----------------- > 2 files changed, 38 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt > delete mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1219.txt > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com