From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Mark Brown <broonie@kernel.org>
Cc: mazziesaccount@gmail.com, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, Robin Gong <yibin.gong@nxp.com>,
Elven Wang <elven.wang@nxp.com>,
Anson Huang <anson.huang@nxp.com>
Subject: Re: [RFC PATCH v1 3/3] regulator: bd718x7: Support SNVS low power state
Date: Wed, 13 Feb 2019 10:33:43 +0200 [thread overview]
Message-ID: <20190213083343.GC12247@localhost.localdomain> (raw)
In-Reply-To: <20190213073827.GB12247@localhost.localdomain>
Hello peeps,
And my apologies! I was in a hurry yesterday. I had to pick up kid kid
from kindegarden and I wanted to send the RFC before that - bad mistake.
Should've learnd by now.
Today I decided to continue work and use combination of
regulator-always-on and regulator-boot-on instead of
rohm,regulator-crucial-for-boot. I was ashtonished by the fact that I
didn't find my latest work from my git. After a while I found unsaved
buffer from another editor instance with changes concerning handling of
"rohm,regulator-crucial-for-boot"...
On Wed, Feb 13, 2019 at 09:38:27AM +0200, Matti Vaittinen wrote:
> Hello Mark,
>
> On Tue, Feb 12, 2019 at 04:08:31PM +0000, Mark Brown wrote:
>
> So with current driver design, even if constrains prevented the
> regulator core from touching the regulators, the driver still changes
> the control to SW. So we need to parse some attribute in the BD718x7
> driver side. Besides, I did not spot a 'do not touch me' property from
> the bindings :)
So no wonder it was not clear that the core constrains were not enough.
Previous patch did not contain the part of change that skipped turning
the regulator control to SW if regulator was marked crucial.
> But after writing all this - I think you are correct. We do not need the
> rohm,regulator-crucial-for-boot. I guess we can check for the
> combination of:
>
> regulator-always-on and regulator-boot-on
>
> and interpret this as "rohm,regulator-crucial-for-boot".
>
> I just think I need to document that those flags are required
> for critical regulators if SNVS is used as reset target even if there
> should be no one touching those regulators.
Anyways, this is still valid - I'll prepare next version with all
intended changes included... :/
Br,
Matti Vaittinen
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
prev parent reply other threads:[~2019-02-13 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 14:16 [RFC PATCH v1 0/3] bd718x7: Support SNVS low power state Matti Vaittinen
2019-02-12 14:17 ` [RFC PATCH v1 1/3] devicetree: bindings: bd718x7: document HW state related ROHM specific properties Matti Vaittinen
2019-02-12 14:18 ` [RFC PATCH v1 2/3] regulator: add regulator_desc_list_voltage_linear_range Matti Vaittinen
2019-02-12 15:34 ` Mark Brown
2019-02-12 14:19 ` [RFC PATCH v1 3/3] regulator: bd718x7: Support SNVS low power state Matti Vaittinen
2019-02-12 16:08 ` Mark Brown
2019-02-13 7:38 ` Matti Vaittinen
2019-02-13 8:33 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213083343.GC12247@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=anson.huang@nxp.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elven.wang@nxp.com \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).