From: Johan Hovold <johan@kernel.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
Date: Wed, 13 Feb 2019 10:05:44 +0100 [thread overview]
Message-ID: <20190213090544.GE28278@localhost> (raw)
In-Reply-To: <20190212210656.GA6642@hector.attlocal.net>
On Tue, Feb 12, 2019 at 03:06:56PM -0600, Andy Gross wrote:
> On Thu, Dec 20, 2018 at 05:17:50PM +0100, Johan Hovold wrote:
> > Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep
> > config.
> >
> > Fixes: 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> > index c5c42e94f387..1d1f7f91739a 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> > @@ -139,7 +139,7 @@
> > };
> >
> > pinconf {
> > - pins = "gpio4", "gpiio5", "gpio6", "gpio7";
> > + pins = "gpio4", "gpio5", "gpio6", "gpio7";
> > drive-strength = <2>;
> > bias-disable;
> > };
>
> I took one in slightly older than this one. However, it doesn't have the fixes
> line.
>
>
> commit ff10032fb309d0baa0b79e28009bf154de08d341
> Author: Jakob Wuhrer <jakobwuhrer@airmail.cc>
> Date: Fri Dec 14 18:01:30 2018 +0100
>
> arm64: dts: qcom: Correct "gpiio" typo in msm8996-pins
>
> gpiio5 is missspelt in msm8996-pins.dtsi, fix that.
>
> Signed-off-by: Jakob Wuhrer <jakobwuhrer@airmail.cc>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
That's funny, submitted six days before mine for a 2+ year old issue.
The typo would prevent the pin from being reconfigured (hence the stable
tag), but at least you'd get a runtime warning when trying to set this
config.
Johan
next prev parent reply other threads:[~2019-02-13 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 16:17 [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig Johan Hovold
2019-02-11 9:37 ` Johan Hovold
2019-02-12 21:06 ` Andy Gross
2019-02-13 9:05 ` Johan Hovold [this message]
2019-02-14 16:14 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213090544.GE28278@localhost \
--to=johan@kernel.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).