From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v4 6/8] dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c"
 compatible string
Date: Wed, 13 Feb 2019 15:18:08 -0600
Message-ID: <20190213211807.GA20560@bogus>
References: <20190204231554.87666-1-ray.jui@broadcom.com>
 <20190204231554.87666-7-ray.jui@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190204231554.87666-7-ray.jui@broadcom.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Ray Jui <ray.jui@broadcom.com>
Cc: Wolfram Sang <wsa@the-dreams.de>, Mark Rutland <mark.rutland@arm.com>, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
List-Id: devicetree@vger.kernel.org

On Mon, Feb 04, 2019 at 03:15:52PM -0800, Ray Jui wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> 
> Update iProc I2C binding document to add new compatible string
> "brcm,iproc-nic-i2c". Optional property "brcm,ape-hsls-addr-mask" is
> also added that allows configuration of the host view into the APE's
> address for "brcm,iproc-nic-i2c"
> 
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
>  Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
> index d3a3620b1f06..02e82d20239e 100644
> --- a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
> @@ -3,7 +3,7 @@ Broadcom iProc I2C controller
>  Required properties:
>  
>  - compatible:
> -    Must be "brcm,iproc-i2c"
> +    Must be "brcm,iproc-i2c" or "brcm,iproc-nic-i2c"
>  
>  - reg:
>      Define the base and range of the I/O address space that contain the iProc
> @@ -24,6 +24,9 @@ Optional properties:
>      Should contain the I2C interrupt. If unspecified, driver will fall back to
>      polling mode
>  
> +- brcm,ape-hsls-addr-mask:
> +    Required for "brcm,iproc-nic-i2c". Host view of address mask into the
> +    'APE' co-processor

What's the data type and size? What are valid values?

>  
>  Example:
>  	i2c0: i2c@18008000 {
> -- 
> 2.17.1
>