From: Lee Jones <lee.jones@linaro.org>
To: Virendra Kakade <virendra.kakade@ni.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, sre@kernel.org, moritz.fischer@ettus.com
Subject: Re: [RFC 3/6] power: supply: Ettus Research E31x charger driver
Date: Thu, 14 Feb 2019 09:38:19 +0000 [thread overview]
Message-ID: <20190214093819.GG13737@dell> (raw)
In-Reply-To: <20190212010143.3729-4-virendra.kakade@ni.com>
On Mon, 11 Feb 2019, Virendra Kakade wrote:
> Document bindings for the E31x devices charger.
>
> Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
> ---
> Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 8 ++++++++
> .../bindings/power/supply/e31x-charger.txt | 14 ++++++++++++++
> 2 files changed, 22 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/e31x-charger.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> index ebb5625f6c74..3798886578ba 100644
> --- a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> +++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> @@ -4,11 +4,19 @@ Required properties:
> - compatible : Must be "ni,e31x-pmu"
> - regmap : Must be <®mapnode>
>
> +e31x-pmu has a sub-device called e31x-charger.
> +
> +For the e31x-charger properties please refer to:
> +Documentation/device-tree/bindings/power/supply/e31x-charger.txt
Use relative path, so:
../power/supply/e31x-charger.txt
> Example:
>
> pmu {
> compatible = "ni,e31x-pmu";
> regmap = <&devctrl>;
> status = "okay";
'\n' here.
> + charger: charger@0{
> + compatible = "ni,e31x-charger";
> + };
> };
>
> diff --git a/Documentation/devicetree/bindings/power/supply/e31x-charger.txt b/Documentation/devicetree/bindings/power/supply/e31x-charger.txt
> new file mode 100644
> index 000000000000..ae9fedcbf1b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/e31x-charger.txt
> @@ -0,0 +1,14 @@
> +Ettus Research/National Instruments E31x Devices Charger
Too many spaces.
> +All E31x devices have to be connected to an external power supply
> +charger to charge the in-built battery or supply power.
> +Some capability is provided to monitor this charger.
Why the linefeed here? Take "Some" up to the previous line.
> +Required properties:
> +- compatible: Must be "ni,e31x-charger"
> +
> +Example:
> +
> +charger: charger@0{
> + compatible = "ni,e31x-charger";
> +};
Not sure this really requires documentation. Seems kinda simple.
I'll leave that up to Rob et al.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-14 9:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 1:01 [RFC 0/6] Add support for Ettus Research E31x devices PMU Virendra Kakade
2019-02-12 1:01 ` [RFC 1/6] mfd: Support " Virendra Kakade
2019-02-12 10:51 ` Moritz Fischer
2019-02-14 9:23 ` Lee Jones
2019-02-12 1:01 ` [RFC 2/6] " Virendra Kakade
2019-02-14 9:34 ` Lee Jones
2019-02-17 16:37 ` Moritz Fischer
2019-02-18 8:56 ` Lee Jones
2019-02-12 1:01 ` [RFC 3/6] power: supply: Ettus Research E31x charger driver Virendra Kakade
2019-02-14 9:38 ` Lee Jones [this message]
2019-02-25 23:38 ` Rob Herring
2019-02-12 1:01 ` [RFC 4/6] " Virendra Kakade
2019-02-12 21:46 ` Sebastian Reichel
2019-02-12 1:01 ` [RFC 5/6] power: supply: Ettus Research E31x battery driver Virendra Kakade
2019-02-14 9:39 ` Lee Jones
2019-02-12 1:01 ` [RFC 6/6] " Virendra Kakade
2019-02-12 22:26 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214093819.GG13737@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=virendra.kakade@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).