From: Lee Jones <lee.jones@linaro.org>
To: Virendra Kakade <virendra.kakade@ni.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, sre@kernel.org, moritz.fischer@ettus.com
Subject: Re: [RFC 5/6] power: supply: Ettus Research E31x battery driver
Date: Thu, 14 Feb 2019 09:39:49 +0000 [thread overview]
Message-ID: <20190214093949.GH13737@dell> (raw)
In-Reply-To: <20190212010143.3729-6-virendra.kakade@ni.com>
On Mon, 11 Feb 2019, Virendra Kakade wrote:
> Document bindings for the E31x devices battery.
>
> Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
> ---
> Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 8 +++++++-
> .../bindings/power/supply/e31x-battery.txt | 14 ++++++++++++++
> 2 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/power/supply/e31x-battery.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> index 3798886578ba..223ab9e0d680 100644
> --- a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> +++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> @@ -4,11 +4,14 @@ Required properties:
> - compatible : Must be "ni,e31x-pmu"
> - regmap : Must be <®mapnode>
>
> -e31x-pmu has a sub-device called e31x-charger.
> +e31x-pmu consists of two sub-devices, e31x-charger and e31x-battery.
>
> For the e31x-charger properties please refer to:
> Documentation/device-tree/bindings/power/supply/e31x-charger.txt
>
> +For the e31x-battery properties please refer to:
> +Documentation/device-tree/bindings/power/supply/e31x-battery.txt
Same comment as I provided in the Charger patch.
> Example:
>
> pmu {
> @@ -18,5 +21,8 @@ pmu {
> charger: charger@0{
> compatible = "ni,e31x-charger";
> };
> + battery: battery@1{
> + compatible = "ni,e31x-battery";
> + };
> };
Still seems kinda simple.
> diff --git a/Documentation/devicetree/bindings/power/supply/e31x-battery.txt b/Documentation/devicetree/bindings/power/supply/e31x-battery.txt
> new file mode 100644
> index 000000000000..e09cd92ef82e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/e31x-battery.txt
> @@ -0,0 +1,14 @@
> +Ettus Research/National Instruments E31x Devices Battery
> +
> +Some variants of the E31x devices have an in-built Li-ion
> +battery. This driver provides capability to monitor
> +the battery.
> +
> +Required properties:
> +- compatible: Must be "ni,e31x-battery"
> +
> +Example:
> +
> +battery: battery@0{
> + compatible = "ni,e31x-battery";
> +};
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-14 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 1:01 [RFC 0/6] Add support for Ettus Research E31x devices PMU Virendra Kakade
2019-02-12 1:01 ` [RFC 1/6] mfd: Support " Virendra Kakade
2019-02-12 10:51 ` Moritz Fischer
2019-02-14 9:23 ` Lee Jones
2019-02-12 1:01 ` [RFC 2/6] " Virendra Kakade
2019-02-14 9:34 ` Lee Jones
2019-02-17 16:37 ` Moritz Fischer
2019-02-18 8:56 ` Lee Jones
2019-02-12 1:01 ` [RFC 3/6] power: supply: Ettus Research E31x charger driver Virendra Kakade
2019-02-14 9:38 ` Lee Jones
2019-02-25 23:38 ` Rob Herring
2019-02-12 1:01 ` [RFC 4/6] " Virendra Kakade
2019-02-12 21:46 ` Sebastian Reichel
2019-02-12 1:01 ` [RFC 5/6] power: supply: Ettus Research E31x battery driver Virendra Kakade
2019-02-14 9:39 ` Lee Jones [this message]
2019-02-12 1:01 ` [RFC 6/6] " Virendra Kakade
2019-02-12 22:26 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214093949.GH13737@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=virendra.kakade@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).